fix: Update table chart configuration labels to sentence case #34438
Conversation
Update capitalization of table chart configuration options in the Customize tab: - "Show Cell bars" → "Show cell bars" - "add colors to cell bars for +/-" → "Add colors to cell bars for +/-" - "basic conditional formatting" → "Basic conditional formatting" - "Custom Conditional Formatting" → "Custom conditional formatting" Updates both table and ag-grid-table plugins and all translation files. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
@sadpandajoe yes but there's a handful of exceptions to the rule, @mistercrunch was taking a look at adding something also |
|
Yeah this PR #34437 would fix all of the non-title-casing in the app (after I get AI to fx the thousands of now-linting error). Seems worthwhile. I'd like to test to see if That concern probably applies to smaller PRs doing this at a smaller scale too. My vote: go ahead with the big bang case-switching and line up a PR to use AI to translate everything ... All a sudden it's quite a bit more work. |
- Update msgid entries in all .po/.pot files for the 4 string changes - Files maintain their original translations, only msgid strings updated - Follows same pattern as PR #34438
…#34438) Co-authored-by: Claude <[email protected]>
Summary
Changes Made
Files Updated
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsxsuperset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsxmessages.potand 21 language-specific.pofiles)Screenshots
Before:
After:
Test plan
🤖 Generated with Claude Code