Bug: dict.copy() always returns None #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the merged defaults copy returned to us, so the old return is instead split into three commands: - copy `defaults` - update the copy with `match.groupdict()` - return the updated copy
netomi
approved these changes
Jul 8, 2025
|
Eh? |
|
the original code returns the result of |
|
Yes, yes, the title of the PR is just wrong. |
brainy
reviewed
Jul 8, 2025
| return defaults.copy().update(match.groupdict()) | ||
| merged_defaults = defaults.copy() | ||
| merged_defaults.update(match.groupdict()) | ||
| return merged_defaults |
There was a problem hiding this comment.
It you can guarantee this is Python 3.5+ (which it should be, 3.6 is EOL), then:
return {**defaults, **match.groupdict()}
Otherwise, the above works with Python 2, too.
asfgit
pushed a commit
that referenced
this pull request
Jul 8, 2025
* tools/hook-scripts/mailer/mailer.py (Config._prep_groups::repos_params): If there's a match for the repository configuration, copy the defaults dict and update it in place before returning the new dict. Patch by: humbedooh git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1927075 13f79535-47bb-0310-9956-ffa450edef68
|
Committed a slightly tweaked patch in r1927075. |
asfgit
pushed a commit
that referenced
this pull request
Jul 8, 2025
(Config.repos_params): don't use "defaults" for the merged values.
The comments make this confusing. Use "merged" for clarity.
[ related to PR #33 ]
git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1927078 13f79535-47bb-0310-9956-ffa450edef68
|
Re-using the "defaults" variable for other purposes made the code confusing, especially with the "fall through" to where the comment mentions nothing to add. I used Daniel's original form, with a new dict named "merged" which is explicitly returned in the if-branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the merged defaults copy returned to us, so the old return is instead split into three commands:
defaultsmatch.groupdict()