[SPARK-56189][PYTHON] Refactor SQL_WINDOW_AGG_ARROW_UDF#55153
Closed
Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56189][PYTHON] Refactor SQL_WINDOW_AGG_ARROW_UDF#55153Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Conversation
Yicong-Huang
force-pushed
the
refactor/window-agg-arrow-udf
branch
from
d2a49bd to
dcb723c
Compare
Contributor
Author
|
retest this please |
Contributor
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor
SQL_WINDOW_AGG_ARROW_UDFto be self-contained inread_udfs(), moving bounded/unbounded window logic from wrapper functions and the old mapper into a single execution block that usesArrowStreamGroupSerializeras pure I/O.This is a re-submission of #55123 which was reverted due to CI failure caused by using a non-existent
num_dfsparameter onArrowStreamSerializer. This version usesArrowStreamGroupSerializerinstead.Why are the changes needed?
Part of SPARK-55388.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
ASV micro-benchmarks with
repeat=(3, 5)show no regression:SQL_WINDOW_AGG_ARROW_UDF (time)
Peak memory: No change (468M-506M for all scenarios).
Was this patch authored or co-authored using generative AI tooling?
No.