Skip to content

[SPARK-56302][CORE] Free task result memory eagerly during serialization on executor #55110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivoson wants to merge 6 commits into
base: master
Choose a base branch
from
+11 −3
Open

[SPARK-56302][CORE] Free task result memory eagerly during serialization on executor #55110

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
822f147
free task result memory eagerly
ivoson Apr 1, 2026
ac31af6
Merge branch 'apache:master' into free-result-memory-asap
ivoson Apr 1, 2026
5cd0a85
try install python 3.12
ivoson Apr 2, 2026
ddb9aab
print default python version
ivoson Apr 2, 2026
b48c5e3
Revert "print default python version"
ivoson Apr 2, 2026
bcffc37
Revert "try install python 3.12"
ivoson Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions core/src/main/scala/org/apache/spark/executor/Executor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import org.apache.spark.status.api.v1.ThreadStackTrace
import org.apache.spark.storage.{StorageLevel, TaskResultBlockId}
import org.apache.spark.util._
import org.apache.spark.util.ArrayImplicits._
import org.apache.spark.util.io.ChunkedByteBuffer

private[spark] object IsolatedSessionState {
// Authoritative store for all isolated sessions. Sessions are put here when created
Expand Down Expand Up @@ -883,7 +884,7 @@ private[spark] class Executor(
val resources = taskDescription.resources.map { case (rName, addressesAmounts) =>
rName -> new ResourceInformation(rName, addressesAmounts.keys.toSeq.sorted.toArray)
}
val value = Utils.tryWithSafeFinally {
var value: Any = Utils.tryWithSafeFinally {
val res = task.run(
taskAttemptId = taskId,
attemptNumber = taskDescription.attemptNumber,
Expand Down Expand Up @@ -938,7 +939,9 @@ private[spark] class Executor(

val resultSer = env.serializer.newInstance()
val beforeSerializationNs = System.nanoTime()
val valueByteBuffer = SerializerHelper.serializeToChunkedBuffer(resultSer, value)
var valueByteBuffer: ChunkedByteBuffer = SerializerHelper.serializeToChunkedBuffer(
resultSer, value)
value = null // Allow GC to reclaim the raw task result
val afterSerializationNs = System.nanoTime()

// Deserialization happens in two parts: first, we deserialize a Task object, which
Expand Down Expand Up @@ -982,10 +985,15 @@ private[spark] class Executor(
val accumUpdates = task.collectAccumulatorUpdates()
val metricPeaks = metricsPoller.getTaskMetricPeaks(taskId)
// TODO: do not serialize value twice
val directResult = new DirectTaskResult(valueByteBuffer, accumUpdates, metricPeaks)
var directResult: DirectTaskResult[Any] = new DirectTaskResult(
valueByteBuffer, accumUpdates, metricPeaks)
// try to estimate a reasonable upper bound of DirectTaskResult serialization
val serializedDirectResult = SerializerHelper.serializeToChunkedBuffer(ser, directResult,
valueByteBuffer.size + accumUpdates.size * 32 + metricPeaks.length * 8)
// Allow GC to reclaim the first serialization buffer. Both references must be
// nulled: the local var and the field inside directResult point to the same object.
valueByteBuffer = null
directResult = null
val resultSize = serializedDirectResult.size
executorSource.METRIC_RESULT_SIZE.inc(resultSize)

Expand Down