[SPARK-53105][Structured Streaming] Fix tests for checkpoint v2 in RocksDBSuite #51834
+24
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bothra90
force-pushed
the
abhay/SPARK-53105
branch
from
781c1ab to
9a92aec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current implementations of
testWithStateStoreCheckpointIdsandtestWithStateStoreCheckpointIdsAndChangelogEnableddon't actually execute the passed test body. Instead, they just return a new closure and indicate successful execution, giving a false sense of security. This PR fixes these test wrappers to correctly execute the test body.Additional change: Now that the tests are running correctly, we had to adjust the number of iterations in
randomized snapshottingtests to reduce the duration for which we had to run the tests.Why are the changes needed?
Since these tests were effectively no-ops, we had a chance of regressions in checkpoint v2 which would have passed undetected.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing and fixed unit tests now pass
Was this patch authored or co-authored using generative AI tooling?
No