[SPARK-53097][CONNECT][SQL] Make WriteOperationV2 in SparkConnectPlanner side effect free #51813
+73
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
violetnspct
reviewed
Aug 5, 2025
| @@ -2660,19 +2660,20 @@ class SparkConnectPlanner( | |||
| def process( | |||
| command: proto.Command, | |||
| responseObserver: StreamObserver[ExecutePlanResponse]): Unit = { | |||
| val transformerOpt = transformCommand(command) | |||
There was a problem hiding this comment.
@heyihong Should unit tests be added to cover the changes in the method process?
The method flow has been significantly altered with new transformation logic and early returns. The PR mentions "Existing tests". Are there existing tests covering the change in the method? If yes, can you please point me to that?
There was a problem hiding this comment.
heyihong
changed the title
cloud-fan
approved these changes
Aug 6, 2025
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refactors the
WriteOperationV2handling inSparkConnectPlannerto make it side-effect free by separating the transformation and execution phases.Why are the changes needed?
Make WriteOperationV2 side-effect free
Does this PR introduce any user-facing change?
No. This is a purely internal refactoring.
How was this patch tested?
Existing tests (e.g. ReadwriterV2ParityTests)
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor 1.3.9