Change volumeMounts and volumes types to array #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Thank you for making a PR, @Sbaia .
To @jiangzho , this seems to be related to SPARK-53640 (Operator Helm Chart: suppot additionalContainers, volumes, volumeMounts as array) which you reported before.
Could you review this? I'm wondering if this PR resolves one of your issues.
Contributor
|
Sorry for the delay - yes, this would act as a partial of SPARK-53640 . @Sbaia - could you please fix the PRBs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request updates the schema definitions in
build-tools/helm/spark-kubernetes-operator/values.schema.jsonto improve compatibility with Kubernetes conventions. The main change is updating the types forvolumeMountsandvolumesfromobjecttoarray, which better reflects how these fields are typically structured in Kubernetes manifests.typeofvolumeMountsfromobjecttoarrayto match standard Kubernetes configuration for container volume mounts.typeofvolumesfromobjecttoarrayto align with Kubernetes pod volume definitions.Why are the changes needed?
bug, cannot use volumes fields, the helm chart fall in error or for values.json validation, or in yaml rendering
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No