SOLR-17742: remove handleSelect requestDispatcher option #3409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd HttpSolrCall.java
dsmiley
requested changes
Jun 28, 2025
| @@ -128,7 +128,7 @@ public enum PluginOpts { | |||
|
|
|||
| private int formUploadLimitKB; | |||
|
|
|||
| private boolean handleSelect; | |||
| // private boolean handleSelect; | |||
There was a problem hiding this comment.
remove this outright; don't leave commented
| @@ -363,7 +363,7 @@ private SolrConfig(SolrResourceLoader loader, String name, Properties substituta | |||
| log.warn("Ignored deprecated enableStreamBody in config; use sys-prop"); | |||
| } | |||
|
|
|||
| handleSelect = get("requestDispatcher").boolAttr("handleSelect", false); | |||
| // handleSelect = get("requestDispatcher").boolAttr("handleSelect", false); | |||
| return handleSelect; | ||
| } | ||
|
|
||
| /** public boolean isHandleSelect() { return handleSelect; } */ |
| @@ -1010,7 +1007,7 @@ public Map<String, Object> toMap(Map<String, Object> result) { | |||
| m, filterCacheConfig, queryResultCacheConfig, documentCacheConfig, fieldValueCacheConfig); | |||
| m = new LinkedHashMap<>(); | |||
| result.put("requestDispatcher", m); | |||
| m.put("handleSelect", handleSelect); | |||
| // m.put("handleSelect", handleSelect); | |||
| @@ -454,25 +453,18 @@ protected void extractHandlerFromURLPath(SolrRequestParsers parser) throws Excep | |||
| if (handler == null && path.length() > 1) { // don't match "" or "/" as valid path | |||
| handler = core.getRequestHandler(path); | |||
| // no handler yet but <requestDispatcher> allows us to handle /select with a 'qt' param | |||
There was a problem hiding this comment.
and this comment is now obsolete/false
There was a problem hiding this comment.
still should remove this comment
|
Precommit failed. Looking at the logs, this is why: |
dsmiley
reviewed
Jun 30, 2025
| @@ -454,25 +453,18 @@ protected void extractHandlerFromURLPath(SolrRequestParsers parser) throws Excep | |||
| if (handler == null && path.length() > 1) { // don't match "" or "/" as valid path | |||
| handler = core.getRequestHandler(path); | |||
| // no handler yet but <requestDispatcher> allows us to handle /select with a 'qt' param | |||
There was a problem hiding this comment.
still should remove this comment
dsmiley
approved these changes
Jun 30, 2025
|
Please search for "handleSelect" more thoroughly. Your changes here are good but incomplete. |
cpoerschke
changed the title
|
Wondering if ref-guide references could be removed too: https://github.com/search?q=repo%3Aapache%2Fsolr+handleSelect+language%3AAsciiDoc&type=code&l=AsciiDoc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd HttpSolrCall.java
https://issues.apache.org/jira/browse/SOLR-17742
Description
handleSelect is removed from solrconfig.xml .The relevant code has been removed
Solution
Tests
All the tests passed
Checklist