Skip to content

GHA renovation #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

GHA renovation #3396

wants to merge 6 commits into from

Conversation

dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Jun 19, 2025

  • branches (all)
  • timeout-minutes
  • checkout version
  • harmonization across scripts (spacing / wording / labels)
  • remove chmod for gradlew (unnecessary)

Caching tweaks: removed this but I'm unsure:
apache/lucene-solr#1910 CC @madrob

@dsmiley
GHA renovation
f154436 
* branches (all)
* timeout-minutes
* checkout version
* harmonization across scripts (spacing / wording / labels)
* remove chmod for gradlew (unnecessary)

Caching tweaks: removed this but I'm unsure:
apache/lucene-solr#1910
madrob
madrob reviewed Jun 19, 2025
View reviewed changes
Copy link
Contributor

@madrob madrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there something wrong with the caching? Were we running up against storage limits? The original comment said it took 5 min off the build which seems pretty significant, especially in a 15 minute timeout

.github/workflows/docker-test.yml
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Install ACL
run: sudo apt-get install acl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need this any more? @HoustonPutman is probably better to look

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in passing tests I trust :-) (which they do)

@dsmiley
Copy link
Contributor Author

dsmiley commented Jun 19, 2025

The elaborate caching configuration is not in Lucene, despite that same elaborate caching configuration being committed before the lucene-solr split. Thus Lucene devs removed it. In particular, it was @dweiss in apache/lucene#13110

I'm going to further improve this PR to use the nice .github/actions/prepare-for-build/action.yml (in Lucene, small tweaks for Solr) refactoring so that each GHA can share it

@dsmiley
Copy link
Contributor Author

dsmiley commented Jun 28, 2025

@madrob when you first added that 5 years ago, we weren't using the GHA gradle action or it didn't exist then. It now does with caching built-in. My goal here is to simplify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madrob madrob madrob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsmiley @madrob