Skip to content

Conversation

@mrproliu
Copy link
Contributor

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#.
  • Update the CHANGES log.

@mrproliu mrproliu added this to the 0.9.0 milestone Nov 20, 2025
@mrproliu mrproliu requested a review from hanahmily November 20, 2025 02:55
@mrproliu mrproliu added the enhancement New feature or request label Nov 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 0.19399% with 1029 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.10%. Comparing base (3530dd9) to head (3619d2d).
⚠️ Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
...anyand/backup/lifecycle/trace_migration_visitor.go 0.00% 340 Missing ⚠️
banyand/backup/lifecycle/progress.go 0.00% 97 Missing ⚠️
banyand/internal/sidx/part.go 0.00% 94 Missing ⚠️
banyand/trace/svc_standalone.go 0.00% 78 Missing ⚠️
banyand/trace/part.go 0.00% 72 Missing ⚠️
banyand/trace/write_data.go 0.00% 68 Missing ⚠️
banyand/backup/lifecycle/service.go 0.00% 64 Missing ⚠️
banyand/measure/snapshot.go 0.00% 63 Missing ⚠️
banyand/stream/snapshot.go 0.00% 63 Missing ⚠️
banyand/backup/lifecycle/migration_integration.go 0.00% 31 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
+ Coverage   45.97%   46.10%   +0.12%     
==========================================
  Files         328      335       +7     
  Lines       55505    52231    -3274     
==========================================
- Hits        25520    24080    -1440     
+ Misses      27909    25838    -2071     
- Partials     2076     2313     +237     
Flag Coverage Δ
banyand 48.34% <0.19%> (?)
bydbctl 81.91% <ø> (?)
integration-distributed 80.00% <ø> (?)
pkg 32.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hanahmily hanahmily modified the milestones: 0.9.0, 0.10 Nov 21, 2025
Comment on lines 42 to 43
traceDataName = "data"
traceKeysName = "keys"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
traceDataName = "data"
traceKeysName = "keys"

They are sidx's files, can not be imported here.

@mrproliu mrproliu requested a review from hanahmily November 21, 2025 06:27
@hanahmily hanahmily merged commit ee009ed into apache:main Nov 27, 2025
21 checks passed
@mrproliu mrproliu deleted the trace-lifecycle branch November 27, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants