You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
jdk8 to jdk17
springboot 2.6 to springboot 3.4.5
remove acl1.0 and support acl2.0
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.
Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
Crazylychee
changed the title
[GSOC][RIP-78][ISSUES#308]: Add part of refactored backend files
[GSOC][RIP-78][ISSUES#308]: Add refactored backend files
Jun 12, 2025
Crazylychee
changed the title
[GSOC][RIP-78][ISSUES#308]: Add refactored backend files
[RIP-78-5]: Add refactored backend files
Jun 13, 2025
Hello @Crazylychee and good job. There are some remaining refactoring about Spring Boot. As an example we can remove the use of @Autowired annotation that is no longer needed since the version Spring 4.3.
You can check this PR I made as an attempt or a POC for the migration, you will find some refactoring samples: #306
Hello @Crazylychee and good job. There are some remaining refactoring about Spring Boot. As an example we can remove the use of @Autowired annotation that is no longer needed since the version Spring 4.3. You can check this PR I made as an attempt or a POC for the migration, you will find some refactoring samples: #306
Oh, I get it. You may mean that we can replace the '@Autowired' and '@resource' of using the Allargsconstructor. That's a good idea. And are you willing to take a pr based on the lastest master?
@Crazylychee Good point, I will take a look on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[RIP-78] part05
Brief changelog
fix #303
fix #305
fix #294
fix #245
fix #243
fix #264
fix #308
Verifying this change
jdk8 to jdk17
springboot 2.6 to springboot 3.4.5
remove acl1.0 and support acl2.0
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.