Skip to content

add new kind of NsResolver: dnsResolver #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add new kind of NsResolver: dnsResolver #1123

wants to merge 1 commit into from

Conversation

vearne
Copy link
Contributor

@vearne vearne commented Dec 27, 2023

What is the purpose of the change

fix #1122

Brief changelog

add new kind of NsResolver: dnsResolver to support nameserver in the form of domain name.

like this

p, err := rocketmq.NewProducer(
	producer.WithNsResolver(primitive.NewDNSResolver([]string{"ns1.example.com:9876"})),
	producer.WithRetry(2),
)

Verifying this change

I have add unit test In primitive/nsresolver_test.go.

@rfyiamcool
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add new kind of primitive.NsResolver
2 participants
@vearne @rfyiamcool