-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][client] Exclude io.prometheus:simpleclient_caffeine from client-side dependencies #24761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 3 commits into
apache:master
from
lhotari:lh-exclude-simpleclient_caffeine-from-client-deps
Sep 19, 2025
Merged
[fix][client] Exclude io.prometheus:simpleclient_caffeine from client-side dependencies #24761
lhotari
merged 3 commits into
apache:master
from
lhotari:lh-exclude-simpleclient_caffeine-from-client-deps
Sep 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… side dependencies - pulsar-common is also shared on client side so the io.prometheus:simpleclient_caffeine dependency should be excluded from client side dependencies
merlimat
approved these changes
Sep 19, 2025
@lhotari there seems to be a class issue in a test:
|
dao-jun
approved these changes
Sep 19, 2025
a9d85b7
to
99e0ddb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24761 +/- ##
=============================================
+ Coverage 38.31% 74.19% +35.88%
- Complexity 13047 33243 +20196
=============================================
Files 1844 1901 +57
Lines 144274 148403 +4129
Branches 16726 17204 +478
=============================================
+ Hits 55279 110109 +54830
+ Misses 81481 29516 -51965
- Partials 7514 8778 +1264
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…-side dependencies (apache#24761)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-4.0
cherry-picked/branch-4.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/4.0.7
release/4.1.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24755
Motivation
io.prometheus:simpleclient_caffeine
dependency to pulsar-common module.io.prometheus:simpleclient_caffeine
dependency should be excluded from client side dependenciesModifications
io.prometheus:simpleclient_caffeine
dependency is excluded from client side dependenciesDocumentation
doc
doc-required
doc-not-needed
doc-complete