Skip to content

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Sep 18, 2025

Fixes #24755

Motivation

Modifications

  • add exclusions to pulsar-common when applicable, so that io.prometheus:simpleclient_caffeine dependency is excluded from client side dependencies
  • improve the way how Prometheus dependency management in pom.xml is handle, start using the BOM

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

… side dependencies

- pulsar-common is also shared on client side so the io.prometheus:simpleclient_caffeine dependency should be excluded from client side dependencies
@lhotari lhotari added this to the 4.2.0 milestone Sep 18, 2025
@lhotari lhotari requested a review from merlimat September 18, 2025 23:01
@lhotari lhotari self-assigned this Sep 18, 2025
@lhotari lhotari added type/bug The PR fixed a bug or issue reported a bug ready-to-test release/4.0.7 release/4.1.1 labels Sep 18, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 18, 2025
@merlimat
Copy link
Contributor

@lhotari there seems to be a class issue in a test:

  Error:  Failures: 
  Error:  org.apache.pulsar.websocket.WebSocketHttpServletRequestWrapperTest.mockRequestTest
  [INFO]   Run 1: PASS
  Error:    Run 2: WebSocketHttpServletRequestWrapperTest.mockRequestTest:76 » NoClassDefFound Could not initialize class org.apache.pulsar.common.stats.CacheMetricsCollector

@lhotari lhotari force-pushed the lh-exclude-simpleclient_caffeine-from-client-deps branch from a9d85b7 to 99e0ddb Compare September 19, 2025 08:52
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.19%. Comparing base (8879b3b) to head (295f33e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #24761       +/-   ##
=============================================
+ Coverage     38.31%   74.19%   +35.88%     
- Complexity    13047    33243    +20196     
=============================================
  Files          1844     1901       +57     
  Lines        144274   148403     +4129     
  Branches      16726    17204      +478     
=============================================
+ Hits          55279   110109    +54830     
+ Misses        81481    29516    -51965     
- Partials       7514     8778     +1264     
Flag Coverage Δ
inttests 26.37% <ø> (-0.12%) ⬇️
systests 22.73% <ø> (+<0.01%) ⬆️
unittests 73.72% <ø> (+39.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1407 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit b11f05f into apache:master Sep 19, 2025
93 of 97 checks passed
lhotari added a commit that referenced this pull request Sep 22, 2025
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
lhotari added a commit that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Pulsar client 4.0.6 fails with Java 8
4 participants