Part 1 : Adds RLS and CLS control Policies #2048
Open
+719
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
proposal in Apache Polaris for the policy spec - https://lists.apache.org/thread/rf2zsgk9qh36z3s63gx6dgtl0s4cwngr |
|
cc @laurentgo |
singhpk234
commented
Jul 14, 2025
| PolicyEntity policyEntity, boolean inherited) { | ||
| private boolean filterApplicablePolicy(PolicyEntity policyEntity) { | ||
| // check the type | ||
| if (policyEntity.getPolicyType().equals(ACCESS_CONTROL)) { |
There was a problem hiding this comment.
Need a PolicyEntityAugmentor which could conditionally modify the object, let me think about it more.
singhpk234
force-pushed
the
feature/fgac-policies
branch
from
6878f0f to
decd92b
Compare
singhpk234
force-pushed
the
feature/fgac-policies
branch
from
decd92b to
85ba526
Compare
|
I'm a bit surprised to see a "ready for review (and merge)" PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This PR adds proposed policy spec proposed as part [OSS] Row and Column Based Access Control: Policy Definitions
This uses iceberg expressions, to define row level filters and uses column projections as way to project, presently since we are just talking of column (waiting for UDF's in Apache Iceberg to standardize), May be we can use transforms for the projections ? open to it !
Note: In last Apache Iceberg Community Sync all were generally alligned that using iceberg expression with extending its support for reference to iceberg UDF's were the right way to go !
This additionally introduces 2 context variables which are resolved at the catalog end based on the caller
$current_prinicipal, checks if the current principal is the principal activated, if yes makes this as true !
$current_principal_role, checks if the the underlying role is one of the activated principal roles based on current caller context !
so a policy being defined with this context variables are replace inline and evaluated using iceberg expression sdk !
so when ever the caller calls /get-applicable-policies it gets back context resolved variables and row and column policy
TODO : Policy merging
please check tests for E2E tests
Note : This is for engines who wants to get the policies directly ! rather than getting the secure view and are willing to integrate to the Polaris Policy Store directly
check this combination
https://docs.google.com/document/d/1AJicez7xPhzwKXenGZ19h0hngxrwAg3rSajDV1v0x-s/edit?tab=t.0#bookmark=id.j29shahtycb8