Add muti-platform Docker images staging in the release guide #2039
Conversation
| You can now publish Docker images on DockerHub: | ||
|
|
||
| ``` | ||
| ./gradlew :polaris-server:assemble :polaris-server:quarkusAppPartsBuild --rerun -Dquarkus.container-image.build=true -Dquarkus.container-image.push=true -Dquarkus.docker.buildx.platform="linux/amd64,linux/arm64" -Dquarkus.container-image.tag=x.y.z-rci |
There was a problem hiding this comment.
What are the machine's requirements for "buildx"? Docker? Podman?
There was a problem hiding this comment.
Docker (we use quarkus-container-image-docker dependency by default).
There was a problem hiding this comment.
Hm, not sure Docker's a great implied requirement due to the licensing implications that it brings for most devs.
There was a problem hiding this comment.
Podman also supports multi-platform images "natively" (without buildx). If we want to use podman, we should update the dependency here: https://github.com/apache/polaris/blob/main/runtime/server/build.gradle.kts#L55 (to use podman instead of docker).
There was a problem hiding this comment.
FYI, last time I tried multi-arch builds with podman, the resulting manifests were corrupted. But, maybe it's fixed/improved now.
There was a problem hiding this comment.
I suspect, it's not an issue (license wise) to use Docker buildx in ASF GH workflows. Just for potentially for devs locally.
There was a problem hiding this comment.
Yes. podman can do multi-arch build without buildx now a day (I used it at work as well). Due to the above concern with licensing around docker, does it makes sense to deprecate docker and promo podman instead? Also, for buildx on docker with Mac/Windows, additional steps are needed on the build machines other than the additional parameters specify above.
One more catch with podman is it will add container registry info (by default docker.io) to the image name. When building with docker, we will get apache/polaris:xxxx. However, if we build with podman, it will then become docker.io/apache/polaris:xxxx. In case if we want to promo podman as oppose to docker, we shoild container add additional parameter to set registry info as part of the image build (so both docke/podman will produce same images name) then update our docs accordingly.
| NB: the docker images (polaris-server and polaris-admin) will be | ||
| published on DockerHub once release vote passes. | ||
|
|
||
| Docker images: |
There was a problem hiding this comment.
Since those are multiplatform images, probably worth to add a link to Dockerhub
No description provided.