Remove duplicate MetaStoreManagerFactory mocks #2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
commented
Jul 10, 2025
| @Override | ||
| public Map<String, PrincipalSecretsResult> bootstrapRealms( | ||
| Iterable<String> realms, RootCredentialsSet rootCredentialsSet) { | ||
| throw new NotImplementedException("Bootstrapping realms is not supported"); |
There was a problem hiding this comment.
was throwing this exception the reason why some tests where using createMockMetaStoreManagerFactory() instead of the Mock in the field?
or just left-over code without a particular reason?
sorry in case i am missing something obvious
There was a problem hiding this comment.
I do not see any test relying on this exception, so removing this piece of code LGTM.
also rename the field for clarity and consistency
XN137
force-pushed
the
duplicate-MetaStoreManagerFactory-mocks
branch
from
267dd57 to
3279432
Compare
snazy
approved these changes
Jul 10, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
approved these changes
Jul 10, 2025
| @Override | ||
| public Map<String, PrincipalSecretsResult> bootstrapRealms( | ||
| Iterable<String> realms, RootCredentialsSet rootCredentialsSet) { | ||
| throw new NotImplementedException("Bootstrapping realms is not supported"); |
There was a problem hiding this comment.
I do not see any test relying on this exception, so removing this piece of code LGTM.
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also rename the field for clarity and consistency