Skip to content

Infra: Configure default squash commit message #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajantha-bhat
Copy link
Member

Fixes #1656

@@ -33,6 +33,7 @@ github:
enabled_merge_buttons:
merge: false
squash: true
squash_commit_message: PR_TITLE_AND_DESC
rebase: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't add merge_commit_message: PR_TITLE_AND_DESC as merge is disabled. Only squash is enabled.

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this deserves a dev-ML discussion first.

TL;DR the current behavior is better, because you get all commit messages in the merge-commit description proposed by GH.
In any way, contributors should review the PR summary and description before opening a PR and committers should really review both the summary and the description of the merge commit, before merging.

@ajantha-bhat
Copy link
Member Author

ok. I will start the discussion.

We could have replied the same for the open issue #1656.
I started working on this thinking we have consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing the repo setting to change how the default message is generated
2 participants