Infra: Configure default squash commit message #2016
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
commented
Jul 9, 2025
| @@ -33,6 +33,7 @@ github: | |||
| enabled_merge_buttons: | |||
| merge: false | |||
| squash: true | |||
| squash_commit_message: PR_TITLE_AND_DESC | |||
| rebase: false | |||
There was a problem hiding this comment.
Didn't add merge_commit_message: PR_TITLE_AND_DESC as merge is disabled. Only squash is enabled.
ajantha-bhat
requested review from
snazy,
jbonofre and
eric-maynard
and removed request for
snazy
snazy
requested changes
Jul 9, 2025
There was a problem hiding this comment.
IMO this deserves a dev-ML discussion first.
TL;DR the current behavior is better, because you get all commit messages in the merge-commit description proposed by GH.
In any way, contributors should review the PR summary and description before opening a PR and committers should really review both the summary and the description of the merge commit, before merging.
|
ok. I will start the discussion. We could have replied the same for the open issue #1656. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1656