Add Delegation Service Module and REST Framework #1981
Conversation
|
cc: @eric-maynard, @flyrain |
williamhyun
changed the title
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
|
Please allow some more review time. From my POV the dev list discussion does not have a conclusion yet 🤔 |
github-project-automation
bot
moved this from Ready to merge
to PRs In Progress
in Basic Kanban Board
| @Path("/api/v1/tasks/execute") | ||
| @Consumes(MediaType.APPLICATION_JSON) | ||
| @Produces(MediaType.APPLICATION_JSON) | ||
| public class DelegationApi { |
There was a problem hiding this comment.
Can we add @experimental here ?
There was a problem hiding this comment.
This isn't a Polaris API, and within the context of the delegation service (itself experimental), this is not really an experimental API.
There was a problem hiding this comment.
My proposal was more to "flag" it experimental (from code perspective). If the "whole" service is experimental, I'm fine with that.
Maybe a couple of tests to illustrate how it works would be welcome.
There was a problem hiding this comment.
From reading the proposal, I think what will actually be experimental will be the RemoteTaskExecutor within Polaris, but that's not implemented in this PR.
There was a problem hiding this comment.
Thank you @jbonofre for your concern! As @eric-maynard has mentioned, the task executor for delegating to the remote service can be flagged as experimental.
In regards to illustrating how it would all work, an end-to-end test is in preparation.
|
The question is which approach two use. There are two proposals on the dev-ML, with no technical pro/con discussion and therefore no decision. As mentioned in other discussions, things do take time. The whole topic is too sensitive and needs to be handled carefully, considering all aspects. Having one proposal not receiving comments and weeks after another, different counter-proposal plus a concrete implementation is not great. |
This PR aims to set up the Delegation Service module for development, starting with the REST API framework.
Discussion thread: