Skip to content

Revert Quarkus version upgrade to unblock IntelliJ build #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adnanhemani
Copy link
Contributor

Details here: #1797 (comment)

@dimas-b
Copy link
Contributor

dimas-b commented Jun 26, 2025

Most tasks work fine in my experience. From my POV, issues with :polaris-server:classes are not substantial enough for reverting a platform upgrade.

@dimas-b
Copy link
Contributor

dimas-b commented Jun 26, 2025

@adnanhemani : feel free to bring this up on the dev ML.

@dimas-b
Copy link
Contributor

dimas-b commented Jun 26, 2025

:polaris-server:compileAll and :polaris-server:assemble work fine.

@snazy : Do you have any insight into the :polaris-server:classes task failure? Perhaps it can be fixed with the current Quarkus version 🤔

@adnanhemani
Copy link
Contributor Author

Here's the failure again if it helps:

ahemani@F7Q5C90CJX polaris % ./gradlew :polaris-server:classes                
Configuration on demand is an incubating feature.
> Task :polaris-server:quarkusGenerateCodeDev FAILED

[Incubating] Problems report is available at: file:///Users/ahemani/Development/polaris/build/reports/problems/problems-report.html

FAILURE: Build failed with an exception.

* What went wrong:
Some problems were found with the configuration of task ':polaris-server:quarkusGenerateCodeDev' (type 'QuarkusGenerateCode').
  - In plugin 'io.quarkus' type 'io.quarkus.gradle.tasks.QuarkusGenerateCode' property 'applicationModel' doesn't have a configured value.
    
    Reason: This property isn't marked as optional and no value has been configured.
    
    Possible solutions:
      1. Assign a value to 'applicationModel'.
      2. Mark property 'applicationModel' as optional.
    
    For more information, please refer to https://docs.gradle.org/8.14.2/userguide/validation_problems.html#value_not_set in the Gradle documentation.
  - In plugin 'io.quarkus' type 'io.quarkus.gradle.tasks.QuarkusGenerateCode' property 'classpath' doesn't have a configured value.
    
    Reason: This property isn't marked as optional and no value has been configured.
    
    Possible solutions:
      1. Assign a value to 'classpath'.
      2. Mark property 'classpath' as optional.
    
    For more information, please refer to https://docs.gradle.org/8.14.2/userguide/validation_problems.html#value_not_set in the Gradle documentation.
  - In plugin 'io.quarkus' type 'io.quarkus.gradle.tasks.QuarkusGenerateCode' property 'generatedOutputDirectory' doesn't have a configured value.
    
    Reason: This property isn't marked as optional and no value has been configured.
    
    Possible solutions:
      1. Assign a value to 'generatedOutputDirectory'.
      2. Mark property 'generatedOutputDirectory' as optional.
    
    For more information, please refer to https://docs.gradle.org/8.14.2/userguide/validation_problems.html#value_not_set in the Gradle documentation.

* Try:
> Assign a value to 'applicationModel'
> Mark property 'applicationModel' as optional
> Assign a value to 'classpath'
> Mark property 'classpath' as optional
> Assign a value to 'generatedOutputDirectory'
> Mark property 'generatedOutputDirectory' as optional
> Run with --scan to get full insights.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.14.2/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 2s

@dimas-b ideally we should not merge anything that breaks development workflows. Even if we do not regress on the version this time, I'd say this should be a blocker for any further upgrades until we get to the bottom of why this happens and what is our workaround.

@dimas-b
Copy link
Contributor

dimas-b commented Jun 27, 2025

Each developer's workflows are different :) There are viable options to continue developing with the current state of the repo as discussed in slack. However, if you feel strongly about this let's continue on the dev list for visibility.

@eric-maynard
Copy link
Contributor

Most tasks work fine in my experience. From my POV, issues with :polaris-server:classes are not substantial enough for reverting a platform upgrade.

What exactly is the upgrade? I didn't see any positive change from bumping the Quarkus version. But I cannot run Quarkus configurations in Intellij after it.

@adnanhemani
Copy link
Contributor Author

However, if you feel strongly about this let's continue on the dev list for visibility.

I agree - wanted to wait and see if @snazy has anything quickly that he can point out. If so, then maybe we sidestep needing a new mail thread altogether. If not, I can start the mail thread :)

@adutra
Copy link
Contributor

adutra commented Jun 27, 2025

FYI: quarkusio/quarkus#48651

@snazy
Copy link
Member

snazy commented Jun 27, 2025

Quarkus Zulip topic

@snazy
Copy link
Member

snazy commented Jun 27, 2025

If reverting to a previous Quarkus version helps, then go for it.

@snazy
Copy link
Member

snazy commented Jun 27, 2025

However, if quarkusBuild works, the revert is not justified IMHO.

@adnanhemani
Copy link
Contributor Author

Seems like Quarkus community has picked up this issue and is working on a fix. If it goes through and fixes our issues, I'm assuming we can just upgrade to that version and abandon this revert. Will keep an eye on this :)

@adnanhemani
Copy link
Contributor Author

Seems like this got fixed in quarkusio/quarkus#48769. Let me verify this is working for us in Quarkus v3.24.3 and modify this PR accordingly.

@adnanhemani
Copy link
Contributor Author

Confirmed that this fixes the original issue. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants