feat(ci): Improve Gradle cache in CI #1928
Open
+250
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
reviewed
Jun 24, 2025
snazy
reviewed
Jun 24, 2025
| description: 'Java version' | ||
| default: '21' | ||
| job-id: | ||
| description: 'Job name to prefer' |
There was a problem hiding this comment.
Nit: the description should actually be
Suggested change
| description: 'Job name to prefer' | |
| description: 'Job ID to prefer' |
snazy
reviewed
Jul 7, 2025
.github/workflows/regtest.yml
Outdated
| @@ -53,9 +61,40 @@ jobs: | |||
| :polaris-server:quarkusAppPartsBuild --rerun \ | |||
| -Dquarkus.container-image.build=true | |||
|
|
|||
| - name: Save partial Gradle build cache | |||
There was a problem hiding this comment.
We should only store the Gradle caches from gradle.yaml, not from other workflows.
It's doesn't make much sense either, because the cache contents are only read, but never modified.
snazy
reviewed
Jul 7, 2025
| # NOTE: the regression test runs with spark 3.5.5 and scala 2.12 in Java 17. We also have integration | ||
| # tests runs with the existing gradle.yml, which only runs on Java 21. Since spark Java compatibility | ||
| # for 3.5 is 8, 11, and 17, we should run spark client with those compatible java versions. | ||
| # TODO: add separate spark client CI and run with Java 8, 11 and 17. | ||
| - name: Regression Test | ||
| run: | | ||
| docker compose -f plugins/spark/v3.5/regtests/docker-compose.yml up --build --exit-code-from regtest | ||
|
|
||
| store-gradle-cache: |
There was a problem hiding this comment.
Looks like we're good if this one is not stored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.