Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

bmsubmit uses BYTEMAN_HOME to locate its jars. It should be set in the ozone-runner image, so that it does not have to be set by all tests that want to use it.

https://issues.apache.org/jira/browse/HDDS-13336

How was this patch tested?

$ ./build.sh
...

$ docker run -it --rm apache/ozone-runner:dev bash

[root@713ebd0dd025 /]# echo $BYTEMAN_HOME
/opt/byteman

[root@713ebd0dd025 /]# ls -la $BYTEMAN_HOME 
total 12
drwxr-xr-x 3 root root 4096 Jun 25 12:20 .
drwxr-xr-x 1 root root 4096 Jun 25 12:20 ..
drwxr-xr-x 2 root root 4096 Jun 25 12:20 lib

[root@713ebd0dd025 /]# ls -la $BYTEMAN_HOME/lib
total 864
drwxr-xr-x 2 root root   4096 Jun 25 12:20 .
drwxr-xr-x 3 root root   4096 Jun 25 12:20 ..
-rw-r--r-- 1 root root  15535 May  1 17:08 byteman-submit.jar
-rw-r--r-- 1 root root 859806 May  1 17:09 byteman.jar

[root@713ebd0dd025 /]# ls -la $(which bmsubmit)
-rwxr-xr-x 1 root root 3449 Apr  9  2018 /usr/local/bin/bmsubmit

[root@713ebd0dd025 /]# ls -la /opt/byteman.jar 
lrwxrwxrwx 1 root root 28 Jun 25 12:20 /opt/byteman.jar -> /opt/byteman/lib/byteman.jar

CI:
https://github.com/adoroszlai/ozone-docker-runner/actions/runs/15876249350/job/44764455447

@adoroszlai adoroszlai self-assigned this Jun 25, 2025
@adoroszlai adoroszlai requested a review from ssulav June 25, 2025 14:51
Copy link
Contributor

@ssulav ssulav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoroszlai adoroszlai merged commit f244908 into apache:master Jun 25, 2025
1 check passed
@adoroszlai adoroszlai deleted the HDDS-13336 branch June 25, 2025 17:43
@adoroszlai
Copy link
Contributor Author

Thanks @ssulav for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants