fix(gooddata): preserve grain for aliased primary-key fields - #347
Open
mattfaltyn wants to merge 1 commit into
Open
fix(gooddata): preserve grain for aliased primary-key fields#347mattfaltyn wants to merge 1 commit into
mattfaltyn wants to merge 1 commit into
Conversation
Signed-off-by: Matt Faltyn <faltyn.matthew@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
primary_keyentries against the converted attribute'ssource_column, which is already derived from the ANSI SQL expression.This keeps the existing behavior for fields whose logical and physical names match while preventing silent loss of key/grain semantics for aliased fields.
Related Issues
Closes #346
Validation
Checklist
Specification
Converters
Documentation
Tests
Compliance