[SUREFIRE-2041] Order test classes according to -Dtest property#495
[SUREFIRE-2041] Order test classes according to -Dtest property#495aslakhellesoy wants to merge 2 commits intoapache:masterfrom
Conversation
8b7e662 to
d4b496c
Compare
| public RunOrderCalculator getRunOrderCalculator() | ||
| { | ||
| return new DefaultRunOrderCalculator( runOrderParameters, getThreadCount() ); | ||
| TestListResolver testListResolver = testRequest.getTestListResolver(); |
There was a problem hiding this comment.
I will try to make a proposal but currently we are before M6 release. The integration test is very good.
The MOJO class should evaluate the string, and if e.g. regex is not supported, throw MOJO failure exception. The string should take parallel path along with TestListResolver during serialization, because it becomes another information for RunOrder, but we must not use TestListResolver. The TestListResolver has nothing to do ordering and it is not a transfer object for -Dtest=.... I will try to do something but not this week.
|
@aslakhellesoy
These are file system based paths which makes the patterns irregular for Java users. |
|
Resolve #2603 |
This is a fix for SUREFIRE-2041.
It introduces a new "test"
RunOrderwhich orders test classes according to the tests specified by-Dtest.I have verified the implementation with both a unit test and an integration test.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
SUREFIRE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.