[GLUTEN-10834][CORE] Prefer hyphens over underscores in shell script names #10836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
Zouxxyy
force-pushed
the
dev/unify-config-name
branch
from
783e1a1 to
0489d69
Compare
|
Run Gluten Clickhouse CI on x86 |
Zouxxyy
changed the title
- over _ in script names where possible
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Zouxxyy
commented
Oct 3, 2025
Zouxxyy
force-pushed
the
dev/unify-config-name
branch
from
6f5d8ed to
202f9bd
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Thank you @Zouxxyy for taking this on! |
PHILO-HE
changed the title
- over _ in script names where possible
PHILO-HE
reviewed
Oct 3, 2025
|
Thank you for the insights @PHILO-HE. We are on the same page. |
Zouxxyy
force-pushed
the
dev/unify-config-name
branch
from
202f9bd to
d80af38
Compare
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
approved these changes
Oct 8, 2025
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
use - as much as possible, unless _ is really needed for a naming in scripts, I checked the scrips in such dirs
How was this patch tested?