[GLUTEN-10797][CH] Reject all JNI calls after native destroy is invoked #10815
+208
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
lgbo-ustc
force-pushed
the
bug_0923_core
branch
from
fa1e5d7 to
2b164dd
Compare
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
lgbo-ustc
force-pushed
the
bug_0923_core
branch
from
2b164dd to
8d50c3e
Compare
|
Run Gluten Clickhouse CI on x86 |
zhanglistar
reviewed
Oct 9, 2025
| for (auto it = active_executors_.begin(); it != active_executors_.end(); ++it) | ||
| { | ||
| auto * executor = *it; | ||
| executor->cancel(); |
There was a problem hiding this comment.
Should we check the result status? maybe fail or something else.
There was a problem hiding this comment.
the result type of cancel is void
| auto * executor = *it; | ||
| executor->cancel(); | ||
| std::cerr << "Not closed LocalExecutor:\n" << executor->dumpPipeline() << std::endl; | ||
| delete executor; |
There was a problem hiding this comment.
Useless, since active_executors_.clear(); will call dtor.
There was a problem hiding this comment.
these are raw pointers, not shared_ptr
lgbo-ustc
force-pushed
the
bug_0923_core
branch
from
8d50c3e to
6f234de
Compare
|
Run Gluten Clickhouse CI on x86 |
lgbo-ustc
force-pushed
the
bug_0923_core
branch
from
6f234de to
feec026
Compare
|
Run Gluten Clickhouse CI on x86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Reject all JNI calls after native destroy is invoked, to prevent access to invalid resources.
How was this patch tested?
test manually