Core: Fail scans when position deletes/DVs don't match data file partition#16957
Open
grantatspothero wants to merge 1 commit into
Open
Core: Fail scans when position deletes/DVs don't match data file partition#16957grantatspothero wants to merge 1 commit into
grantatspothero wants to merge 1 commit into
Conversation
Member
|
@amogh-jahagirdar - This is a validation to make sure if we see delete files that are not in the correct partition as their target data files we will fail rather than silently ignore them. Wdyt? Worth the complexity? |
…ition Position deletes and deletion vectors that reference a data file by path must carry the same partition spec and partition tuple as that data file. When they differ the metadata is corrupt.
grantatspothero
force-pushed
the
gn/failTableScansIfCorruptedMetadataFound
branch
from
ba2f990 to
df32994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Position deletes/DVs with partition values that differ from referenced data files are invalid and corrupt per iceberg spec:
https://iceberg.apache.org/spec/#scan-planning
This PR fails table scans when corrupt metadata is detected.
See linked PR for discussion: #16939