BigQuery: Make BigQueryMetastoreCatalog.initialize() with client argument public#16930
Open
ascend1 wants to merge 1 commit into
Open
BigQuery: Make BigQueryMetastoreCatalog.initialize() with client argument public#16930ascend1 wants to merge 1 commit into
ascend1 wants to merge 1 commit into
Conversation
…public The 5-argument initialize() overload that accepts a pre-built BigQueryMetastoreClient was @VisibleForTesting / package-private. External callers who need to inject a custom-credentialed client (e.g. service-account impersonation, OAuth tokens) had to resort to reflection. Making this overload public provides a stable, supported API for that use case. A related issue apache#13036 was rasied before but closed due to inactivity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 5-argument
BigQueryMetastoreCatalog.initialize()overload that accepts a pre-builtBigQueryMetastoreClientwas@VisibleForTestingand package-private. External callers who need to inject a custom-credentialed client (e.g. service-account impersonation, OAuth tokens) had to resort to reflection. Making this overload public provides a stable, supported API for that use case.A related issue #13036 was rasied before but closed due to inactivity.
Testing
Relying on existing tests and they should all pass as before.