HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part17. #7934
+1,487
−1,310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
slfan1989
reviewed
Sep 7, 2025
| Configuration conf = new HdfsConfiguration(); | ||
| conf.setInt(DFSConfigKeys.DFS_DATANODE_BALANCE_MAX_NUM_CONCURRENT_MOVES_KEY, 0); | ||
| testBalancer1Internal (conf); | ||
| Assertions.assertThrows(HadoopIllegalArgumentException.class, () -> { |
There was a problem hiding this comment.
It is best to use static imports.
slfan1989
reviewed
Sep 7, 2025
| @@ -1448,14 +1459,15 @@ public void testBalancerDispatchHotBlockTimeInterval() { | |||
| Object hotBlockTimeInterval = field1.get(dispatcher); | |||
| assertEquals(1000, (long)hotBlockTimeInterval); | |||
| } catch (Exception e) { | |||
| Assert.fail(e.getMessage()); | |||
| Assertions.fail(e.getMessage()); | |||
There was a problem hiding this comment.
It is best to use static imports.
slfan1989
reviewed
Sep 7, 2025
| @@ -184,7 +185,7 @@ static void runBalancer(Suite s, | |||
| // start rebalancing | |||
| final Collection<URI> namenodes = DFSUtil.getInternalNsRpcUris(s.conf); | |||
| final int r = Balancer.run(namenodes, s.parameters, s.conf); | |||
| Assert.assertEquals(ExitStatus.SUCCESS.getExitCode(), r); | |||
| Assertions.assertEquals(ExitStatus.SUCCESS.getExitCode(), r); | |||
slfan1989
reviewed
Sep 7, 2025
| Assert.assertEquals(totalBlocks - 2, info.numNodes()); | ||
| Assert.assertEquals(totalBlocks * 2 - 2, info.getCapacity()); | ||
| Assertions.assertEquals(totalBlocks - 2, info.numNodes()); | ||
| Assertions.assertEquals(totalBlocks * 2 - 2, info.getCapacity()); |
There was a problem hiding this comment.
Thanks for the feedback—I’ll make the updates right away!
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
zhtttylz
force-pushed
the
hadoop-hdfs-part17
branch
from
c5f4ff6 to
d825a69
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
approved these changes
Sep 8, 2025
|
Thanks @slfan1989 for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part17.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?