HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part13. #7890

zhtttylz · 2025-08-21T06:33:30Z

Description of PR

JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part13.

How was this patch tested?

Junit Test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

leosanqing · 2025-08-21T11:17:12Z

...roject/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/FSImageTestUtil.java

@@ -445,8 +445,8 @@ public static void assertFileContentsDifferent(
  public static Map<File, String> getFileMD5s(File... files) throws Exception {
    Map<File, String> ret = Maps.newHashMap();
    for (File f : files) {
-      assertTrue("Must exist: " + f, f.exists());
-      ret.put(f, getFileMD5(f));
+        assertTrue(f.exists(), "Must exist: " + f);


Hi, it looks like there might be an extra indent here.

Thank you very much for the review—I’ll update the code as soon as possible.

slfan1989 · 2025-08-21T15:46:10Z

...-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/FSAclBaseTest.java

@@ -22,7 +22,7 @@
 import static org.apache.hadoop.fs.permission.AclEntryScope.*;
 import static org.apache.hadoop.fs.permission.AclEntryType.*;
 import static org.apache.hadoop.fs.permission.FsAction.*;
-import static org.junit.Assert.*;
+import static org.junit.jupiter.api.Assertions.*;


Thanks for the review! I’ll push the updates shortly.

hadoop-yetus · 2025-08-24T00:50:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 47 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	46m 37s		trunk passed
+1 💚	compile	1m 27s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 14s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	1m 21s		trunk passed
+1 💚	mvnsite	1m 20s		trunk passed
+1 💚	javadoc	1m 14s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 42s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 16s		trunk passed
+1 💚	shadedclient	43m 36s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 7s		the patch passed
+1 💚	compile	1m 18s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 18s		the patch passed
+1 💚	compile	1m 4s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	1m 4s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	1m 9s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 173 new + 1373 unchanged - 230 fixed = 1546 total (was 1603)
+1 💚	mvnsite	1m 11s		the patch passed
+1 💚	javadoc	1m 1s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 33s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 14s		the patch passed
+1 💚	shadedclient	43m 7s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	202m 29s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 49s		The patch does not generate ASF License warnings.
		359m 27s

Reason	Tests
Failed junit tests	hadoop.hdfs.web.TestWebHDFSAcl

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7890/2/artifact/out/Dockerfile
GITHUB PR	#7890
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 585410d491cb 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6d2dab9`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7890/2/testReport/
Max. process+thread count	2008 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7890/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-08-24T17:34:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 48 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	44m 57s		trunk passed
+1 💚	compile	1m 26s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 15s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	1m 20s		trunk passed
+1 💚	mvnsite	1m 23s		trunk passed
+1 💚	javadoc	1m 14s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 40s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 16s		trunk passed
+1 💚	shadedclient	43m 40s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 8s		the patch passed
+1 💚	compile	1m 20s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 20s		the patch passed
+1 💚	compile	1m 5s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	1m 5s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 6s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 1343 unchanged - 260 fixed = 1347 total (was 1603)
+1 💚	mvnsite	1m 10s		the patch passed
+1 💚	javadoc	1m 3s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 31s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	3m 15s		the patch passed
+1 💚	shadedclient	43m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	201m 35s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 53s		The patch does not generate ASF License warnings.
		356m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7890/3/artifact/out/Dockerfile
GITHUB PR	#7890
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ddb93f14cfe2 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `fb8f454`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7890/3/testReport/
Max. process+thread count	2295 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7890/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part13.

94768c7

github-actions bot added HDFS trunk labels Aug 21, 2025

leosanqing reviewed Aug 21, 2025

View reviewed changes

slfan1989 reviewed Aug 21, 2025

View reviewed changes

trigger test again.

6d2dab9

fix checkstyle.

fb8f454

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part13. #7890

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part13. #7890

zhtttylz commented Aug 21, 2025

Uh oh!

leosanqing Aug 21, 2025

Uh oh!

zhtttylz Aug 21, 2025

Uh oh!

slfan1989 Aug 21, 2025

Uh oh!

zhtttylz Aug 22, 2025

Uh oh!

hadoop-yetus commented Aug 24, 2025

Uh oh!

hadoop-yetus commented Aug 24, 2025

Uh oh!

Uh oh!

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part13. #7890

Are you sure you want to change the base?

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part13. #7890

Conversation

zhtttylz commented Aug 21, 2025

Description of PR

How was this patch tested?

For code changes:

Uh oh!

leosanqing Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

zhtttylz Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

slfan1989 Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

zhtttylz Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Aug 24, 2025

Uh oh!

hadoop-yetus commented Aug 24, 2025

Uh oh!

Uh oh!