[#9238] fix(authz): fix list tags for columns error #9257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where listing tags on columns failed due to missing authorization handling for the COLUMN entity type. The fix adds proper hierarchy extraction for column identifiers, ensuring that authorization checks can properly validate access through the column's parent entities (table, schema, catalog).
Key Changes
- Added COLUMN case handling in
MetadataAuthzHelper.spiltMetadataNames()to extract parent entity identifiers - Implemented
getTableIdentifier()utility method to extract table identifiers from column identifiers - Added integration test
testListColumnTag()to verify column tag listing works correctly
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server-common/src/main/java/org/apache/gravitino/server/authorization/MetadataAuthzHelper.java | Added COLUMN case to extract parent entity hierarchy (table, schema, catalog) for authorization checks |
| core/src/main/java/org/apache/gravitino/utils/NameIdentifierUtil.java | Implemented getTableIdentifier() method to extract table identifier from column identifiers |
| clients/client-java/src/test/java/org/apache/gravitino/client/integration/test/authorization/TagOperationsAuthorizationIT.java | Added integration test to verify column tag listing with authorization enabled |
core/src/main/java/org/apache/gravitino/utils/NameIdentifierUtil.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/gravitino/utils/NameIdentifierUtil.java
Outdated
Show resolved
Hide resolved
Contributor
|
Could you correct your description? |
…il.java Co-authored-by: Copilot <[email protected]>
…il.java Co-authored-by: Copilot <[email protected]>
jerqi
reviewed
Nov 26, 2025
| String metalake, Entity.EntityType entityType, NameIdentifier nameIdentifier) { | ||
| Map<Entity.EntityType, NameIdentifier> nameIdentifierMap = new HashMap<>(); | ||
| nameIdentifierMap.put(Entity.EntityType.METALAKE, NameIdentifierUtil.ofMetalake(metalake)); | ||
| switch (entityType) { |
Contributor
There was a problem hiding this comment.
I have added the two methods
parentEntityType
and
parentNameIdentifier
You can use these methods to refactor the logic.
Contributor
|
Wait for CI. LGTM. |
Contributor
|
Could u correct the description? |
Collaborator
Author
fixed |
hdygxsj
changed the title
jerqi
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix list tags for columns error
Why are the changes needed?
Fix: #9238
Does this PR introduce any user-facing change?
None
How was this patch tested?
org.apache.gravitino.client.integration.test.authorization.TagOperationsAuthorizationIT#testListColumnTag