Skip to content

Conversation

@NazaninAnsarii
Copy link

Summary of Changes:
This Pull Request improves the validation in the SetModelVersionProperty function to prevent both alias and version from being set simultaneously. Additionally, new unit tests have been added to ensure the correctness of these validations.

Reason for Changes:
These changes are made to avoid errors caused by setting both alias and version at the same time, enhancing the robustness and stability of the code.

Tests:
New unit tests have been written to ensure that the validation works correctly and provides appropriate error messages when necessary.

Impact of Changes:
These changes affect the behavior of the SetModelVersionProperty function and contribute to the overall quality and reliability of the codebase.

…nd version from being set simultaneously and add unit tests for validation
@justinmclean
Copy link
Member

We use spotless to ensure that the code is consistently formatted. You'll need to run ./gradlew :api:spotlessApply and commit the changes to fix the CI issue.

@justinmclean
Copy link
Member

@NazaninAnsarii are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants