monkeypatchingly fix #14331 by restarting vnc container (geb) #14995
Conversation
test: proof of bug
There was a problem hiding this comment.
Thank you @JonasPammer & Great Work Around!
My only concern is not cleaning up the recordings - can we clean those up unless some setting is set? Otherwise, running grails tests locally will constantly add more recordings.
| //} | ||
| tasks.withType(Test).configureEach { | ||
| systemProperty('grails.geb.recording.mode', 'RECORD_ALL') | ||
| systemProperty('grails.geb.recording.restartPerTest', 'true') |
There was a problem hiding this comment.
Can we add a doLast { } and remove the recordings after a test run? Otherwise it will continually add them every run locally.
There was a problem hiding this comment.
@jdaugherty I think users would want the videos for review like reports and they would be removed by clean or cleanTests.
grails-geb/src/testFixtures/groovy/grails/plugin/geb/GrailsGebSettings.groovy
Outdated
Show resolved
Hide resolved
|
@JonasPammer Thank you for working on this. |
And also, do not use an external url in the test.
|
thanks, from JonasPammer#1 (comment) |
| // //systemProperty('grails.geb.recording.mode', 'RECORD_ALL') | ||
| //} | ||
| tasks.withType(Test).configureEach { | ||
| systemProperty('grails.geb.recording.mode', 'RECORD_ALL') |
There was a problem hiding this comment.
We still need some type of cleanup of these recordings or they just grow and grow.
Original, Upstream Open Issue: testcontainers/testcontainers-java#3998
The other upstream solution that was suggested, i.e. testcontainers/testcontainers-java#577, seemed way out of bound / too big of a change (that also relies on internals and commands, i.e. volitale to flv.py changes) to hack into here
i also tried a non-reflection attempt, i.e. to manage an own vnc and disable the container's interbound one -- https://gitkraken.dev/link/drafts/3d723754-a136-45c9-bb6f-8cad74600a88?type=patch. but decided to commit this here for comments.
i know reflection code will have a low chance. but at least this also contains a test one could add with Spock-Annotation of "Fails right now".
Edit: Closes #14331