[ISSUE #4763] Do some code optimization.[EventMeshCommon] #4764

scwlkq · 2024-02-01T17:03:42Z

Motivation

move EventMeshCommon class to Common module.

Modifications

Documentation

Does this pull request introduce a new feature? (no)

…eadUtils] (apache#4297) * Update ThreadUtils.java * Update ThreadUtils.java

…ectors] (apache#4314) * [ISSUE apache#4266]: Retore interrupted state for interrupted exception in open function sinc connector * [ISSUE apache#4266]: Retore interrupted state for interrupted exception in open function source connector * [ISSUE apache#4266]: Retore interrupted state for interrupted exception in RocketMQSink connector

…pache#4315) * [ISSUE apache#4093]: Refactor package building chunks to reusable method * [ISSUE apache#4093]: Refactor user agent building chunks to reusable method

…aced with lambda[HelloTask] (apache#4316) * [4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask] * Upgraded: First Interaction Action Version to Latest * [4260] Removed: Unused Import * Update package import order in HelloTask.java --------- Co-authored-by: mike_xwm <[email protected]>

* fix: add cloudEventCodec for redis connector. * fix: add cloudEventCodec for redis connector. * fix import order. * fix: add doc. * fix: adjust cloudevent encode and decode.

…-offsetStorage

…che#4337) * issue-4262 Enhancement Request EventMeshCloudEventUtils * issue-4262 Enhancement Request EventMeshCloudEventUtils move on top method getValue * issue-4262 Enhancement Request EventMeshCloudEventUtils remove redundant else for Optional.of --------- Co-authored-by: maxim.zgardan <[email protected]>

[ISSUE apache#4328] Add offsetManagement Service for connectors

[ISSUE apache#4268] Used switch to replace the if-else [CloudEventsProtocolAdaptor]

[ISSUE apache#4283] Add event-bridge example

… test coverage rate (apache#4340) * issues apache#4264 commit * unit * issues apache#4339 unit test coverage * issues apache#4339 WebhookProtocolTransportObjectTest fix * issues apache#4339 WebhookProtocolTransportObjectTest fix * issues apache#4339 WebhookProtocolTransportObjectTest fix * issues apache#4339 WebhookProtocolTransportObjectTest fix * issues apache#4339 check style * issues apache#4339 new instance replace builder. * issues apache#4339 WebhookProtocolTransportObjectTest unit test. * issues apache#4339 check style. * issues apache#4339 check style. * issues apache#4339 check style. * fixed. * fixed. * fixed. * fixed. * fixed. * delete java bean unit test. * fix build error.

codecov · 2024-02-02T13:36:22Z

Codecov Report

Attention: Patch coverage is 39.76064% with 906 lines in your changes missing coverage. Please review.

Project coverage is 16.37%. Comparing base (1600c6b) to head (d751223).
Report is 4691 commits behind head on master.

Files with missing lines	Patch %	Lines
...mesh/connector/jdbc/connection/JdbcConnection.java	0.00%	137 Missing ⚠️
...nnector/file/sink/connector/FileSinkConnector.java	0.00%	62 Missing ⚠️
...g/apache/eventmesh/common/utils/JsonPathUtils.java	0.00%	54 Missing ⚠️
...ava/org/apache/eventmesh/common/utils/LogUtil.java	7.54%	48 Missing and 1 partial ⚠️
...tor/jdbc/connection/mysql/MysqlJdbcConnection.java	0.00%	43 Missing ⚠️
...dingtalk/sink/connector/DingDingSinkConnector.java	65.38%	24 Missing and 3 partials ⚠️
...pache/eventmesh/connector/jdbc/CatalogChanges.java	0.00%	26 Missing ⚠️
...ava/org/apache/eventmesh/connector/jdbc/Field.java	0.00%	24 Missing ⚠️
...ava/org/apache/eventmesh/common/ThreadWrapper.java	59.64%	16 Missing and 7 partials ⚠️
...tor/http/source/connector/HttpSourceConnector.java	67.74%	14 Missing and 6 partials ⚠️
... and 92 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4764      +/-   ##
============================================
- Coverage     16.93%   16.37%   -0.56%     
- Complexity     1413     1734     +321     
============================================
  Files           589      856     +267     
  Lines         25786    31266    +5480     
  Branches       2397     2700     +303     
============================================
+ Hits           4367     5121     +754     
- Misses        20983    25665    +4682     
- Partials        436      480      +44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…y server (apache#4739) * fix 4738 * fix some bug * fix bug * remove initProducerManager from AbstractRemotingServer init * bug fix * bug fix * some enhance * some enhance * add admin bootstrap * some enhance * remove HttpHandlerManager and ClientManageController. * modify some unit test * add admin http handlermanager

Pil0tXia

Not all members in the EventMeshCommon class are shared across the entire project. Some members are used in the client.tcp package, while others are used in both the sdk module and the client package.

Therefore, it is not a good idea to directly move the EventMeshCommon class, which originally belongs to the client.tcp package, to the common module. It requires a more detailed and clear separation to unify all related usages.

…_patch_4763 * 'fix_patch_4763' of github.com:scwlkq/eventmesh: move EventMeshCommon class to common module

Pil0tXia · 2024-02-20T17:10:47Z

Is there any obstacles in this PR?

scwlkq · 2024-02-21T11:50:45Z

Is there any obstacles in this PR?

Closed because I thought the issue was meaningless hahaha.

eventmesh-common/src/main/java/org/apache/eventmesh/common/EventMeshCommon.java

Pil0tXia

EventMeshCommon class is designed to store constants of EventMesh SDK. It should be kept in org.apache.eventmesh.client package although it is referenced by other protocols.

github-actions · 2024-06-10T18:33:17Z

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions · 2024-08-11T18:34:34Z

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions · 2025-04-14T18:38:07Z

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions · 2025-06-14T18:37:32Z

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

qqeasonchen and others added 30 commits July 31, 2023 22:07

Update bug_report.yml (apache#4308)

af61f73

Update documentation_related.yml (apache#4307)

b4f2b69

Update feature_request.yml (apache#4306)

8fa63b6

Update enhancement_request.yml (apache#4305)

77b87f9

[ISSUE 4309] Fix http process error (apache#4310)

94dbdaa

Update documentation_related.yml (apache#4311)

a48410c

Merge branch 'apache:master' into developmentEM

d19baa5

Update enhancement_request.yml (apache#4312)

7fd6e3d

Update feature_request.yml (apache#4313)

3592263

[ISSUE apache#4171]support pulsar connector (apache#4186)

dd40227

[ISSUE apache#4263] InterruptedExceptions should never be ignored[Thr…

dff6e7a

…eadUtils] (apache#4297) * Update ThreadUtils.java * Update ThreadUtils.java

[ISSUE apache#4093]Repeat code extraction as method.[MessageUtils] (a…

99bcf67

…pache#4315) * [ISSUE apache#4093]: Refactor package building chunks to reusable method * [ISSUE apache#4093]: Refactor user agent building chunks to reusable method

modify the offset management service

4121332

[Feature apache#4032] Fix redis codec (apache#4301)

19dd2b1

* fix: add cloudEventCodec for redis connector. * fix: add cloudEventCodec for redis connector. * fix import order. * fix: add doc. * fix: adjust cloudevent encode and decode.

modify the nacos config management service

939db45

modify the configs

8ab4000

[ISSUE apache#4264]Some optimizations for ProducerService (apache#4334)

800b628

Merge branch 'master' of https://github.com/apache/eventmesh into add…

4a12417

…-offsetStorage

fix ci check error

4f612f1

fix ci check error

4eddf36

fix ci check error

9621900

[ISSUE apache#4085] Switching order (apache#4338)

9d67039

Merge pull request apache#4329 from xwm1992/add-offsetStorage

50bbaec

[ISSUE apache#4328] Add offsetManagement Service for connectors

fix template not taking effect (apache#4325)

97157f8

Merge pull request apache#4298 from devCod3r/developmentEM

8732dd3

[ISSUE apache#4268] Used switch to replace the if-else [CloudEventsProtocolAdaptor]

Merge pull request apache#4284 from seriouszyx/yixiang/event-bridge

4568c50

[ISSUE apache#4283] Add event-bridge example

scwlkq changed the title ~~[#ISSUE 4763] Do some code optimization.[EventMeshCommon]~~ [ISSUE #4763] Do some code optimization.[EventMeshCommon] Feb 3, 2024

Pil0tXia reviewed Feb 5, 2024

View reviewed changes

scwlkq added 2 commits February 15, 2024 22:10

Merge branch 'fix_patch_4763' of github.com:scwlkq/eventmesh into fix…

49b04ae

…_patch_4763 * 'fix_patch_4763' of github.com:scwlkq/eventmesh: move EventMeshCommon class to common module

move some simple usage constants

a64c5d3

scwlkq closed this Feb 15, 2024

scwlkq deleted the fix_patch_4763 branch February 15, 2024 16:28

scwlkq restored the fix_patch_4763 branch February 21, 2024 11:40

scwlkq reopened this Feb 21, 2024

Pil0tXia reviewed Feb 21, 2024

View reviewed changes

eventmesh-common/src/main/java/org/apache/eventmesh/common/EventMeshCommon.java Outdated Show resolved Hide resolved

move constant OPEN_MESSAGE_PROTOCOL_NAME to EventMeshCommon.clss

d751223

scwlkq requested a review from Pil0tXia March 25, 2024 14:01

Pil0tXia requested changes Apr 11, 2024

View reviewed changes

github-actions bot added Stale and removed Stale labels Jun 10, 2024

Pil0tXia added the waiting for contributor PR is awaiting the contributor's response to the review for further evaluation. label Jun 12, 2024

github-actions bot added the Stale label Aug 11, 2024

xwm1992 force-pushed the master branch from 4ea9f76 to e8fdcd3 Compare February 13, 2025 03:23

github-actions bot removed the Stale label Feb 13, 2025

github-actions bot added Stale and removed Stale labels Apr 14, 2025

github-actions bot added Stale and removed Stale labels Jun 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ISSUE #4763] Do some code optimization.[EventMeshCommon] #4764

[ISSUE #4763] Do some code optimization.[EventMeshCommon] #4764

Uh oh!

scwlkq commented Feb 1, 2024

Uh oh!

codecov bot commented Feb 2, 2024 •

edited

Loading

Uh oh!

Pil0tXia left a comment

Uh oh!

Pil0tXia commented Feb 20, 2024

Uh oh!

scwlkq commented Feb 21, 2024

Uh oh!

Uh oh!

Pil0tXia left a comment

Uh oh!

github-actions bot commented Jun 10, 2024

Uh oh!

github-actions bot commented Aug 11, 2024

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

Uh oh!

[ISSUE #4763] Do some code optimization.[EventMeshCommon] #4764

Are you sure you want to change the base?

[ISSUE #4763] Do some code optimization.[EventMeshCommon] #4764

Uh oh!

Conversation

scwlkq commented Feb 1, 2024

Motivation

Modifications

Documentation

Uh oh!

codecov bot commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pil0tXia left a comment

Choose a reason for hiding this comment

Uh oh!

Pil0tXia commented Feb 20, 2024

Uh oh!

scwlkq commented Feb 21, 2024

Uh oh!

Uh oh!

Pil0tXia left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 10, 2024

Uh oh!

github-actions bot commented Aug 11, 2024

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

Uh oh!

codecov bot commented Feb 2, 2024 •

edited

Loading