fix(dataZoom): fix cases with dataset, relates to #16978 #21039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
There are a lot of failed test cases since #16978 . These problems happen when using dataset with dataZoom.
Fixed issues
Details
Before: What was the problem?
Many cases fail because
const dimIndices = map(normalizeDimensions(dims), this._getStoreDimIndex, this);
returns -1 for passing'x'
as a dim but in fact is a string defined in dataset.After: How does it behave after the fixing?
These problems are fixed and the chart can render correctly as the last version.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information