Skip to content

Conversation

liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Aug 22, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #54395

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liaoxin01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.63% (16805/28181)
Line Coverage 48.57% (152915/314848)
Region Coverage 37.54% (116293/309796)
Branch Coverage 40.43% (51310/126907)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.18% (22692/27611)
Line Coverage 74.88% (235652/314695)
Region Coverage 62.09% (195778/315292)
Branch Coverage 66.24% (84708/127876)

@doris-robot
Copy link

TPC-H: Total hot run time: 33602 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0f5dd2ffa52d4d2ea91bf408ba46e347aad3d691, data reload: false

------ Round 1 ----------------------------------
q1	17594	5286	5124	5124
q2	1928	282	183	183
q3	10307	1270	706	706
q4	10231	982	531	531
q5	7526	2403	2296	2296
q6	183	160	128	128
q7	918	730	591	591
q8	9298	1327	1035	1035
q9	6887	5061	5082	5061
q10	6940	2362	1942	1942
q11	483	294	264	264
q12	352	360	211	211
q13	17753	3713	2999	2999
q14	229	227	218	218
q15	549	494	480	480
q16	435	415	378	378
q17	597	842	334	334
q18	7387	7032	7071	7032
q19	1273	940	570	570
q20	336	341	227	227
q21	4064	2585	2318	2318
q22	1052	1020	974	974
Total cold run time: 106322 ms
Total hot run time: 33602 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5292	5179	5160	5160
q2	241	314	219	219
q3	2171	2686	2256	2256
q4	1306	1753	1321	1321
q5	4191	4372	4428	4372
q6	226	182	132	132
q7	2094	1954	1807	1807
q8	2602	2538	2508	2508
q9	7398	7226	7276	7226
q10	3128	3381	2933	2933
q11	625	536	494	494
q12	718	793	645	645
q13	3486	4013	3270	3270
q14	286	305	269	269
q15	514	470	628	470
q16	499	490	429	429
q17	1151	1583	1360	1360
q18	7874	7724	7530	7530
q19	882	896	1033	896
q20	1994	1956	1792	1792
q21	4757	4239	4284	4239
q22	1092	1028	1010	1010
Total cold run time: 52527 ms
Total hot run time: 50338 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183510 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0f5dd2ffa52d4d2ea91bf408ba46e347aad3d691, data reload: false

query1	1003	395	413	395
query2	6523	1753	1737	1737
query3	6742	221	215	215
query4	26615	23210	22896	22896
query5	4362	606	471	471
query6	313	200	211	200
query7	4632	494	285	285
query8	273	236	220	220
query9	8601	2844	2837	2837
query10	485	320	288	288
query11	16106	15371	14955	14955
query12	160	122	110	110
query13	1674	552	417	417
query14	9243	5632	5611	5611
query15	214	184	159	159
query16	7423	626	478	478
query17	1194	726	627	627
query18	2016	417	317	317
query19	188	192	159	159
query20	131	121	117	117
query21	209	122	114	114
query22	4248	4086	3952	3952
query23	33724	32793	32749	32749
query24	8117	2333	2363	2333
query25	520	456	415	415
query26	1234	272	156	156
query27	2741	495	346	346
query28	4400	2240	2188	2188
query29	738	547	451	451
query30	282	226	200	200
query31	909	774	706	706
query32	79	74	77	74
query33	550	365	332	332
query34	785	837	499	499
query35	811	855	744	744
query36	999	1009	913	913
query37	123	113	88	88
query38	4095	4005	3965	3965
query39	1476	1434	1414	1414
query40	218	120	113	113
query41	58	57	55	55
query42	118	104	116	104
query43	491	492	489	489
query44	1335	839	861	839
query45	171	171	164	164
query46	853	992	638	638
query47	1762	1802	1772	1772
query48	390	406	307	307
query49	729	471	380	380
query50	651	676	401	401
query51	4059	4205	4002	4002
query52	118	112	110	110
query53	240	253	186	186
query54	585	584	507	507
query55	87	88	84	84
query56	322	304	322	304
query57	1208	1188	1110	1110
query58	275	258	272	258
query59	2638	2682	2574	2574
query60	340	330	315	315
query61	130	125	117	117
query62	799	738	671	671
query63	219	183	184	183
query64	4278	1026	687	687
query65	4332	4219	4186	4186
query66	1134	408	315	315
query67	15195	15142	15015	15015
query68	8294	915	567	567
query69	465	334	279	279
query70	1235	1110	1107	1107
query71	454	321	313	313
query72	5380	4593	4701	4593
query73	714	573	348	348
query74	9004	9149	8876	8876
query75	3749	3067	2600	2600
query76	3676	1132	723	723
query77	784	392	321	321
query78	9484	9778	8825	8825
query79	2277	829	580	580
query80	759	524	480	480
query81	462	264	219	219
query82	420	139	104	104
query83	283	247	281	247
query84	290	99	81	81
query85	782	366	331	331
query86	354	311	287	287
query87	4238	4304	4179	4179
query88	2808	2171	2147	2147
query89	388	315	280	280
query90	1927	241	214	214
query91	138	136	111	111
query92	88	68	69	68
query93	1154	1006	632	632
query94	680	404	304	304
query95	389	311	304	304
query96	483	572	276	276
query97	2687	2790	2598	2598
query98	224	211	211	211
query99	1450	1450	1286	1286
Total cold run time: 272193 ms
Total hot run time: 183510 ms

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

ClickBench: Total hot run time: 32.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0f5dd2ffa52d4d2ea91bf408ba46e347aad3d691, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.05	0.05
query3	0.25	0.07	0.08
query4	1.63	0.11	0.11
query5	0.43	0.42	0.42
query6	1.14	0.62	0.64
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.51	0.50
query10	0.57	0.56	0.55
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.61	0.61
query14	0.79	0.83	0.82
query15	0.85	0.87	0.86
query16	0.39	0.39	0.38
query17	1.06	1.04	1.07
query18	0.21	0.20	0.19
query19	1.91	1.86	1.83
query20	0.01	0.01	0.01
query21	15.39	0.97	0.60
query22	0.79	1.21	0.73
query23	14.80	1.40	0.63
query24	6.97	1.59	0.64
query25	0.54	0.22	0.09
query26	0.51	0.18	0.14
query27	0.05	0.06	0.05
query28	9.56	0.93	0.44
query29	12.64	3.93	3.23
query30	3.12	2.96	3.04
query31	2.82	0.60	0.40
query32	3.25	0.58	0.47
query33	3.08	3.13	3.07
query34	15.71	5.42	4.85
query35	4.89	4.86	4.93
query36	0.70	0.50	0.52
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.19	0.13	0.14
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.3 s
Total hot run time: 32.34 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 22, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 00c9a4e into apache:master Aug 24, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants