feat: add topologySpreadConstraints support and respect user-provided…#466
Open
plastikman wants to merge 1 commit intoapache:masterfrom
Open
feat: add topologySpreadConstraints support and respect user-provided…#466plastikman wants to merge 1 commit intoapache:masterfrom
plastikman wants to merge 1 commit intoapache:masterfrom
Conversation
… affinity This commit introduces two related scheduling enhancements: 1. Add topologySpreadConstraints field to BaseSpec (aggregated cluster) and CommonSpec (disaggregated cluster) for more flexible pod distribution control. 2. Change affinity behavior to fully respect user-provided configuration: - If user provides affinity, use it as-is without injecting defaults - Only apply default soft podAntiAffinity when user hasn't specified any affinity This allows users to configure scenarios like hard zone spreading with soft node spreading using topologySpreadConstraints, which was not possible before. Files modified: - api/doris/v1/types.go: Add TopologySpreadConstraints to BaseSpec - api/disaggregated/v1/types.go: Add TopologySpreadConstraints to CommonSpec - pkg/common/utils/resource/pod.go: Pass through TopologySpreadConstraints, simplify constructAffinity to respect user config - pkg/controller/sub_controller/disaggregated_subcontroller.go: Simplify ConstructDefaultAffinity to respect user config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… affinity
This commit introduces two related scheduling enhancements:
Add topologySpreadConstraints field to BaseSpec (aggregated cluster) and CommonSpec (disaggregated cluster) for more flexible pod distribution control.
Change affinity behavior to fully respect user-provided configuration:
This allows users to configure scenarios like hard zone spreading with soft node spreading using topologySpreadConstraints, which was not possible before.
Files modified:
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
TopologySpreadConstraints are not added to the operator, i use these for my infrastructure. please add them
Release note
None
Check List (For Author)
This change was tested by applying the patch, building a new operator and deploying in my AKS cluster.
Behavior changed:
In my infrastructure i use topology spread constraints to keep pods scheduled on different nodes and AZ's the operator does not support this. This PR adds this ability if they are not set nothing changes