fix: Avoid panicing when stats are not available for a file group split#23277
Open
mkleen wants to merge 1 commit into
Open
fix: Avoid panicing when stats are not available for a file group split#23277mkleen wants to merge 1 commit into
mkleen wants to merge 1 commit into
Conversation
f8c0e85 to
cba5503
Compare
56c9cef to
3490ba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The query from the issue:
panics:
The underlying issue is that the current code panics when files are split by statistics and there are no statistics available for the column where the sort order is defined in this case
computed_bucket.What changes are included in this PR?
MinMaxStatisticsto check if there are stats available for a given columnAre these changes tested?
Yes
Are there any user-facing changes?
No