Fuse multiple scalar-aggregate subqueries over the same source into a single scan#23214
Draft
nathanb9 wants to merge 1 commit into
Draft
Fuse multiple scalar-aggregate subqueries over the same source into a single scan#23214nathanb9 wants to merge 1 commit into
nathanb9 wants to merge 1 commit into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When a query computes several uncorrelated scalar-aggregate subqueries over the same source, DataFusion scans that source once per subquery. When the subqueries share an identical source, they can be computed in a single scan by pushing each predicate into a
FILTER (WHERE ...)clause.What changes are included in this PR?
A new logical optimizer rule,
FuseScalarSubqueries, gated bydatafusion.optimizer.enable_fuse_scalar_subqueries(default off). When a projection contains 2 or more uncorrelated scalar-aggregate subqueries over a structurally identical source, the rule fuses them into a single aggregate:The source filter becomes the OR of the branch predicates, and each scalar subquery is replaced by a reference to the merged aggregate column. The rule runs before subquery decorrelation and is conservative: it skips correlated,
DISTINCT, ordered, or volatile aggregates, and predicates containing subqueries.This is an initial, opt-in version mirroring the existing
enable_unions_to_filterrule. Follow-ups could add a size or selectivity guard.