Skip to content

Conversation

@codetyri0n
Copy link
Contributor

@codetyri0n codetyri0n commented Nov 25, 2025

Which issue does this PR close?

Rationale for this change

  • deprecating is_nullable in favour of return_field as it is already encoded within return_field

Are these changes tested?

  • yes

Are there any user-facing changes?

  • Deprecated method

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates labels Nov 25, 2025
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly fewer changes than I expected

@codetyri0n codetyri0n force-pushed the deprecate_is_nullable branch from 7f99f29 to 810cae5 Compare November 26, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate AggregateUDFImpl::is_nullable in favour of return_field

2 participants