-
Notifications
You must be signed in to change notification settings - Fork 619
Support remaining pipe operators #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @simonvandel! The changes look good to me overall! left some comments
Hi @iffyio and thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @simonvandel! Just one comment re vec index and I think this should be good!
src/parser/mod.rs
Outdated
// Take first | ||
let join = joins.swap_remove(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here can we add a condition to guard the vec indexing, so that we don't panic if our assumption or code is wrong for any reason? i.e.
if joins.len() != 1 {
return Err(...)
}
let join = joins.swap_remove(0);
And maybe for the comment we can elaborate on if/why we expect exactly one entry in the returned join response? thinking since that might not be obvious for folks that stumble on this part of the code later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! 552714a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @simonvandel!
cc @alamb
Fixes #1758
This PR adds support for the remaining SQL pipe operators as defined by BigQuery.