Skip to content

Chore: Refactor QueryPlanSerde, move math exprs in separate file #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kazantsev-maksim
Copy link
Contributor

@kazantsev-maksim kazantsev-maksim commented Jul 12, 2025

Which issue does this PR close?

Part of #2019

Rationale for this change

See #2019 for rationale.

What changes are included in this PR?

  • Moved maths expressions to separate file (maths.scala)

How are these changes tested?

There are no functional changes, so rely on existing tests.

@andygrove
Copy link
Member

There is some overlap between this PR and #2018, but I can rebase #2018 on this PR later, if needed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 75.36232% with 34 lines in your changes missing coverage. Please review.

Project coverage is 58.67%. Comparing base (f09f8af) to head (861ffd2).
Report is 326 commits behind head on main.

Files with missing lines Patch % Lines
.../src/main/scala/org/apache/comet/serde/maths.scala 74.04% 15 Missing and 19 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2027      +/-   ##
============================================
+ Coverage     56.12%   58.67%   +2.54%     
- Complexity      976     1237     +261     
============================================
  Files           119      135      +16     
  Lines         11743    13041    +1298     
  Branches       2251     2379     +128     
============================================
+ Hits           6591     7652    +1061     
- Misses         4012     4168     +156     
- Partials       1140     1221      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants