chore: Comet CI with Iceberg 1.9.1 #1950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsiang-c
commented
Jun 27, 2025
hsiang-c
commented
Jun 27, 2025
| iceberg-version: [{short: '1.8', full: '1.8.1'}] | ||
| spark-version: [{short: '3.5', full: '3.5.6'}] | ||
| iceberg-version: [{short: '1.8', full: '1.8.1'}, {short: '1.9', full: '1.9.1'}] | ||
| spark-version: [{short: '3.4', full: '3.4.4'}, {short: '3.5', full: '3.5.6'}] |
There was a problem hiding this comment.
Use Spark 3.4.4 instead of 3.4.3 b/c Iceberg 1.9.1 depends on it: https://github.com/apache/iceberg/blob/apache-iceberg-1.9.1/gradle/libs.versions.toml#L82
There was a problem hiding this comment.
Thanks, I do not think we need to test Spark 3.4.4 with Iceberg 1.9.1 then.
3.4.4 is not tested for any other locations https://datafusion.apache.org/comet/user-guide/installation.html#supported-spark-versions
Let's remove 3.4.4
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
============================================
+ Coverage 56.12% 58.20% +2.07%
- Complexity 976 1152 +176
============================================
Files 119 133 +14
Lines 11743 13037 +1294
Branches 2251 2420 +169
============================================
+ Hits 6591 7588 +997
- Misses 4012 4216 +204
- Partials 1140 1233 +93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hsiang-c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #. #1685
Rationale for this change
Test latest Iceberg release.
What changes are included in this PR?
Same as #1715
How are these changes tested?