chore: prune stale NOTICE.txt entries, add mini-redis attribution - #2300
Merged
Conversation
NOTICE.txt was inherited from Apache Arrow and listed bundled works that Ballista does not contain: LLVM, google-lint (cpplint), CMake, Jekyll, Apache Kudu, and Apache ORC. These are all Arrow C++ / build-system artifacts with no counterpart in this pure-Rust repo. Reduce NOTICE.txt to the required ASF attribution and refresh the copyright end year. While auditing, found that ballista/executor/src/shutdown.rs is based on Tokio's mini-redis example (MIT), which was not attributed. Add it to LICENSE.txt alongside the existing Apache Aurora entry, with the full MIT text since MIT requires the notice travel with the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — housekeeping, no issue filed.
Rationale for this change
NOTICE.txtwas inherited when Ballista was split out of the Arrow repo, and still lists bundled works that Ballista does not contain. Everything removed below is an Arrow C++ or build-system artifact with no counterpart in this pure-Rust repo:llvmmatch in the tree is a passing mention in a doc comment (ballista/core/src/kll.rs:337)jekyllmatch istouch .nojekyllin.github/workflows/docs.yamlCarrying entries for software we don't ship makes the file misleading about what's actually bundled, which is the one thing
NOTICE.txtexists to communicate.What changes are included in this PR?
NOTICE.txt— reduced to the required ASF attribution, and the copyright end year refreshed to 2026:LICENSE.txt— while auditing what is bundled,ballista/executor/src/shutdown.rsturned out to be based on Tokio's mini-redis example (MIT) and was not attributed anywhere. Added an entry after the existing Apache Aurora one, with the full MIT text inline, since MIT requires the notice and permission text travel with the code — a URL alone isn't sufficient the way it is for the Apache-2.0 Aurora entry.The split follows ASF policy:
NOTICE.txtcarries only required ASF attribution, and third-party bundled works belong inLICENSE.txt. Two other copied-from sites were checked and need nothing —ballista-cli/src/tui/app.rsand.../aqe/execution_plan/dynamic_join.rsboth copy from DataFusion, which is ASF Apache-2.0 with a plain NOTICE.Are there any user-facing changes?
No code or API changes. The contents of
NOTICE.txtandLICENSE.txtship in release artifacts, so this is user-visible in that narrow sense.