TEXT-239: TextStringBuilder.append(char[], int, int) uses wrong variable in exception message #735
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
requested changes
Jan 27, 2026
Member
There was a problem hiding this comment.
Hello @inponomarev
Thank you for this PR.
If the same error exists elsewhere, please fix it in this PR as well.
Note that I updated the master branch's Checkstyle rules to catch missing finals for locals.
Contributor
Author
|
Hi @garydgregory , thank you for reviewing this. |
garydgregory
added a commit
that referenced
this pull request
Jan 28, 2026
variable in exception message #735 Use longer lines Keep test methods in AB order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes TEXT-239 by correcting the exception message in
TextStringBuilder.append(char[], int, int)when startIndex is invalid.A regression test is included to verify both invalid length and invalid startIndex cases report the correct variable.
StrBuilderimplementations (commons-text/commons-lang). This PR intentionally limits the change toTextStringBuilder