[Veeam] Don't interrupt backup syncronization by SadiJr · Pull Request #7225 · apache/cloudstack

SadiJr · 2023-02-14T19:35:07Z

Description

When ACS is synchronizing the Veeam backups, if one backup fails in this process, all the other backups are skipped and ignored. This behavior is fixed by this PR; if one backup fails in syncronization, only this backup is skipped, and the others continue the process.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

It was tested in a local lab:

I created two VMs, added these VMs to one backup offering, and made two manual backups;
I renamed the backup in Veeam of one of then;
Before, ACS failed in the syncronization process because the first backup failed to syncronize;
Now, the ACS doesn't interrupt the synchronization process of the rest of the backups.

codecov · 2023-02-14T20:39:17Z

Codecov Report

Merging #7225 (e344588) into main (45616aa) will increase coverage by 0.11%.
Report is 8 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #7225      +/-   ##
============================================
+ Coverage     29.16%   29.28%   +0.11%     
- Complexity    30377    30516     +139     
============================================
  Files          5100     5100              
  Lines        358273   359113     +840     
  Branches      52304    52593     +289     
============================================
+ Hits         104496   105161     +665     
- Misses       239406   239540     +134     
- Partials      14371    14412      +41

Flag	Coverage Δ
simulator-marvin-tests	`25.34% <0.00%> (+0.14%)`	⬆️
uitests	`4.87% <ø> (ø)`
unit-tests	`14.42% <0.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...rg/apache/cloudstack/backup/BackupManagerImpl.java	`39.08% <0.00%> (-0.33%)`	⬇️

... and 39 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarqubecloud · 2023-02-21T15:31:06Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

DaanHoogland · 2023-05-23T07:53:42Z

@blueorangutan package

blueorangutan · 2023-05-23T07:54:04Z

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-05-23T09:31:51Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6118

DaanHoogland · 2023-05-23T18:05:20Z

@blueorangutan test rocky8 vmware-70u2

blueorangutan · 2023-05-23T18:06:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u2) has been kicked to run smoke tests

blueorangutan · 2023-05-23T18:09:16Z

Trillian Build Failed (tid-6569)

blueorangutan · 2023-05-24T03:53:11Z

Trillian test result (tid-6571)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 26891 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7225-t6571-vmware-70u3.zip
Smoke tests completed. 86 look OK, 0 have errors, 24 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
all_test_safe_shutdown	`Skipped`	---	test_safe_shutdown.py
all_test_metrics_api	`Skipped`	---	test_metrics_api.py
all_test_outofbandmanagement	`Skipped`	---	test_outofbandmanagement.py
all_test_outofbandmanagement_nestedplugin	`Skipped`	---	test_outofbandmanagement_nestedplugin.py
all_test_routers_iptables_default_policy	`Skipped`	---	test_routers_iptables_default_policy.py
all_test_secondary_storage	`Skipped`	---	test_secondary_storage.py
all_test_service_offerings	`Skipped`	---	test_service_offerings.py
all_test_storage_policy	`Skipped`	---	test_storage_policy.py
all_test_templates	`Skipped`	---	test_templates.py
all_test_update_security_group	`Skipped`	---	test_update_security_group.py
all_test_usage_events	`Skipped`	---	test_usage_events.py
all_test_vm_autoscaling	`Skipped`	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	`Skipped`	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	`Skipped`	---	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	`Skipped`	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_snapshot_kvm	`Skipped`	---	test_vm_snapshot_kvm.py
all_test_vm_snapshots	`Skipped`	---	test_vm_snapshots.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

harikrishna-patnala

code LGTM

DaanHoogland

clgtm, will trust the users to approve with testing

DaanHoogland · 2023-07-03T12:57:18Z

@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2023-07-03T12:58:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

harikrishna-patnala · 2023-07-19T09:51:42Z

@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2023-07-19T09:52:03Z

@harikrishna-patnala a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

GutoVeronezi · 2023-08-22T20:34:51Z

@blueorangutan package

@DaanHoogland @harikrishna-patnala could we run another round of tests? Seems that we had a problem with blueorangutan in the last run.

blueorangutan · 2023-08-22T20:36:03Z

@GutoVeronezi a [SF] Jenkins job has been kicked to build packages. It will be bundled with@DaanHoogland @harikrishna-patnala could we run another round of tests? Seems that we had a problem with blueorangutan in the last run. SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-08-22T21:14:36Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6862

weizhouapache · 2023-08-23T05:45:45Z

@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2023-08-23T05:46:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2023-08-23T06:33:42Z

[SF] Trillian Build Failed (tid-7520)

harikrishna-patnala · 2023-08-24T07:51:09Z

@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2023-08-24T07:52:03Z

@harikrishna-patnala a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

SadiJr · 2023-09-11T14:11:43Z

@DaanHoogland @harikrishna-patnala @GutoVeronezi could we run another round of tests? Seems that we had a problem with blueorangutan in the last run.

harikrishna-patnala · 2023-09-18T04:07:41Z

@blueorangutan package

blueorangutan · 2023-09-18T04:08:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-09-18T05:00:50Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7036

harikrishna-patnala · 2023-09-18T09:45:11Z

@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2023-09-18T09:46:03Z

@harikrishna-patnala a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2023-09-19T08:48:57Z

[SF] Trillian test result (tid-7671)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 81177 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7225-t7671-vmware-70u3.zip
Smoke tests completed. 109 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.04	test_ssvm.py
test_02_upgrade_kubernetes_cluster	`Failure`	610.95	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	714.53	test_kubernetes_clusters.py
test_list_vms_metrics_admin	`Error`	3622.54	test_metrics_api.py
test_list_vms_metrics_history	`Error`	7.96	test_metrics_api.py
test_list_volumes_metrics_history	`Error`	3624.53	test_metrics_api.py
test_01_deploy_vm_on_specific_host	`Error`	4.39	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	12.55	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	3603.97	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	4.46	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	12.63	test_vm_deployment_planner.py

DaanHoogland · 2023-09-19T08:52:16Z

insanity:
@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2023-09-19T08:54:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2023-09-19T23:09:22Z

[SF] Trillian test result (tid-7690)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49462 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7225-t7690-vmware-70u3.zip
Smoke tests completed. 113 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

shwstppr · 2023-10-05T08:29:09Z

Merging based on reviews and smoke test results

Don't interrupt backup sincronization when some backup fails

df257e7

boring-cyborg Bot added the component:backup label Feb 14, 2023

DaanHoogland reviewed Feb 15, 2023

View reviewed changes

Comment thread server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java Outdated

SadiJr added 2 commits February 21, 2023 11:19

Fix method call

7a0aa5a

Address Daan review

205b9ec

Merge branch 'main' into veeam-dont-interrupt-backup-sincronization

d8a1665

apache deleted a comment from blueorangutan May 23, 2023

DaanHoogland added this to the 4.19.0.0 milestone Jun 22, 2023

yadvr requested a review from harikrishna-patnala June 27, 2023 11:42

harikrishna-patnala approved these changes Jul 3, 2023

View reviewed changes

DaanHoogland approved these changes Jul 3, 2023

View reviewed changes

Merge branch 'main' into veeam-dont-interrupt-backup-sincronization

e14c50a

Merge branch 'main' into veeam-dont-interrupt-backup-sincronization

86c006c

Merge branch 'main' into veeam-dont-interrupt-backup-sincronization

e344588

DaanHoogland closed this Sep 20, 2023

DaanHoogland reopened this Sep 20, 2023

shwstppr merged commit 4c59dea into apache:main Oct 5, 2023

SadiJr deleted the veeam-dont-interrupt-backup-sincronization branch October 10, 2023 19:03

Uh oh!

Conversation

SadiJr commented Feb 14, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecov Bot commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

sonarqubecloud Bot commented Feb 21, 2023

Uh oh!

DaanHoogland commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

DaanHoogland commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 24, 2023

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 3, 2023

Uh oh!

blueorangutan commented Jul 3, 2023

Uh oh!

harikrishna-patnala commented Jul 19, 2023

Uh oh!

blueorangutan commented Jul 19, 2023

Uh oh!

GutoVeronezi commented Aug 22, 2023

Uh oh!

blueorangutan commented Aug 22, 2023

Uh oh!

blueorangutan commented Aug 22, 2023

Uh oh!

weizhouapache commented Aug 23, 2023

Uh oh!

blueorangutan commented Aug 23, 2023

Uh oh!

blueorangutan commented Aug 23, 2023

Uh oh!

harikrishna-patnala commented Aug 24, 2023

Uh oh!

blueorangutan commented Aug 24, 2023

Uh oh!

SadiJr commented Sep 11, 2023

Uh oh!

harikrishna-patnala commented Sep 18, 2023

Uh oh!

blueorangutan commented Sep 18, 2023

Uh oh!

blueorangutan commented Sep 18, 2023

Uh oh!

harikrishna-patnala commented Sep 18, 2023

Uh oh!

blueorangutan commented Sep 18, 2023

Uh oh!

blueorangutan commented Sep 19, 2023

Uh oh!

DaanHoogland commented Sep 19, 2023

Uh oh!

blueorangutan commented Sep 19, 2023

Uh oh!

blueorangutan commented Sep 19, 2023

codecov Bot commented Feb 14, 2023 •

edited

Loading