Improve logs when searching one storage pool to allocate a new volume - #7212
Merged
DaanHoogland merged 5 commits intoSep 28, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7212 +/- ##
============================================
- Coverage 29.16% 28.37% -0.79%
+ Complexity 30377 29179 -1198
============================================
Files 5100 5100
Lines 358273 358295 +22
Branches 52304 52304
============================================
- Hits 104496 101676 -2820
- Misses 239406 242645 +3239
+ Partials 14371 13974 -397
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 210 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
SonarCloud Quality Gate failed. |
stephankruggg
approved these changes
Mar 2, 2023
stephankruggg
left a comment
stephankruggg
left a comment
Contributor
There was a problem hiding this comment.
CLGTM, not manually tested
Member
|
Could you please provide a sample snippet of the new improved logs so that i can verify it. |
Contributor
Author
@kiranchavala sorry for the delay to answer you, sure I can provide some samples: Please tell me if you need more information. |
JoaoJandre
approved these changes
Sep 26, 2023
JoaoJandre
left a comment
JoaoJandre
left a comment
Contributor
There was a problem hiding this comment.
CLGTM, these will help troubleshooting a lot
Member
|
@blueorangutan package |
|
@kiranchavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7140 |
kiranchavala
approved these changes
Sep 28, 2023
kiranchavala
left a comment
kiranchavala
left a comment
Member
There was a problem hiding this comment.
LGTM, Tested it manually and found the log messages are improved. the storage pool name and uuid is included in the logs
Before the fix
2023-09-28 11:21:30,104 DEBUG [o.a.c.s.a.LocalStoragePoolAllocator] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) LocalStoragePoolAllocator is returning null since the disk profile does not use local storage and bypassStorageTypeCheck is false.
2023-09-28 11:21:30,104 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Looking for pools in dc [1], pod [1] and cluster [1]. Disabled pools will be ignored.
2023-09-28 11:21:30,105 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Found pools [[Pool[1|NetworkFilesystem]]] that match with tags [[]].
2023-09-28 11:21:30,105 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Checking if storage pool is suitable, name: ref-trl-5653-k-M7-kiran-chavala-kvm-pri1 ,poolId: 1
2023-09-28 11:21:30,106 INFO [c.c.s.StorageManagerImpl] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Storage pool ref-trl-5653-k-M7-kiran-chavala-kvm-pri1 (1) does not supply IOPS capacity, assuming enough capacity
2023-09-28 11:21:30,107 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Checking pool 1 for storage, totalSize: 2197949513728, usedBytes: 1165863419904, usedPct: 0.5304323018441622, disable threshold: 0.95
2023-09-28 11:21:30,107 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Destination pool id: 1
2023-09-28 11:21:30,113 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Pool ID for the volume with ID 57 is null
2023-09-28 11:21:30,115 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Found storage pool ref-trl-5653-k-M7-kiran-chavala-kvm-pri1 of type NetworkFilesystem with overprovisioning factor 2
2023-09-28 11:21:30,115 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Total over provisioned capacity calculated is 2 * (1.9990 TB) 2197949513728
2023-09-28 11:21:30,115 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-22:ctx-f48de3b6 job-714 ctx-8ccf0016) (logid:87badcb9) Total capacity of the pool ref-trl-5653-k-M7-kiran-chavala-kvm-pri1 with ID 1 is (3.9980 TB) 4395899027
After the fix
2023-09-28 11:25:58,229 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Calling StoragePoolAllocators to find suitable pools
2023-09-28 11:25:58,230 DEBUG [o.a.c.s.a.LocalStoragePoolAllocator] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) LocalStoragePoolAllocator is returning null since the disk profile does not use local storage and bypassStorageTypeCheck is false.
2023-09-28 11:25:58,231 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Looking for pools in dc [1], pod [1] and cluster [1]. Disabled pools will be ignored.
2023-09-28 11:25:58,232 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Found pools [[Pool[2|NetworkFilesystem], Pool[3|NetworkFilesystem]]] that match with tags [[]].
2023-09-28 11:25:58,233 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Checking if storage pool [{"name":"ref-trl-5739-k-M7-kiran-chavala-kvm-pri1","uuid":"374453df-869e-3530-9ec1-a0c23a7917fd"}] is suitable to disk [DskChr[ROOT|8589934592|]].
2023-09-28 11:25:58,234 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Volume [Vol[3|name=ROOT-3|vm=3|ROOT]] is not allocated to any pool. Cannot check compatibility with pool [{"name":"ref-trl-5739-k-M7-kiran-chavala-kvm-pri1","uuid":"374453df-869e-3530-9ec1-a0c23a7917fd"}].
2023-09-28 11:25:58,234 INFO [c.c.s.StorageManagerImpl] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Storage pool ref-trl-5739-k-M7-kiran-chavala-kvm-pri1 (2) does not supply IOPS capacity, assuming enough capacity
2023-09-28 11:25:58,235 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Checking pool 2 for storage, totalSize: 2197949513728, usedBytes: 1171369492480, usedPct: 0.5329373969528578, disable threshold: 0.95
2023-09-28 11:25:58,235 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Destination pool id: 2
2023-09-28 11:25:58,241 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Pool ID for the volume with ID 3 is null
2023-09-28 11:25:58,243 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Found storage pool ref-trl-5739-k-M7-kiran-chavala-kvm-pri1 of type NetworkFilesystem with overprovisioning factor 2
2023-09-28 11:25:58,243 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Total over provisioned capacity calculated is 2 * (1.9990 TB) 2197949513728
2023-09-28 11:25:58,243 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-27:ctx-36c13530 job-31 ctx-8d381d6f) (logid:b79c25c2) Total capacity of the pool ref-trl-5739-k-M7-kiran-chavala-kvm-pri1 with ID 2 is (3.9980 TB) 4395899027456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The process of searching a storage pool to allocate a new volume does not have enough logs for effective troubleshooting. Thus, new logs were added in this process, aiming to facilitate future troubleshooting.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
It was tested in a local lab: