Create API to reassign volume by JoaoJandre · Pull Request #6938 · apache/cloudstack

JoaoJandre · 2022-12-01T18:12:35Z

Description

ACS has an API to change the account that owns a VM; however, it is not possible to perform the same type of operation for volumes. Therefore, we created the API assignVolume to allow the transition of volumes between accounts. For this, the user executing the operation needs the following:

permission to the assignVolume API
must be able to access the account that will receive the volume
must be able to access the volume being moved to a new account

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

N	Test	Result	Expected behavior?
1	Call the API to change a volume's owner between two different accounts	the volume's owner was changed	yes
2	Call the API to change the volume's owner to its own account	Exception	yes
3	Call the API to change the volume's owner to a disabled account	Exception	yes
4	Call the API to change the volume's owner to a locked account	Exception	yes
5	Call the API to change the volume's owner while the volume is attached	Exception	yes
6	Call the API to change the volume's owner while the volume has a snapshot	Exception	yes
7	Call the API to change a volume's owner between two different accounts, while the volume is on the secondary storage	The volume was moved from the original accounts secondary storage directory to the new owner's secondary storage directory and then was reassigned	yes

sonarqubecloud · 2022-12-01T19:12:01Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

29.0% Coverage
0.0% Duplication

codecov · 2022-12-01T19:15:39Z

Codecov Report

Merging #6938 (690d2c1) into main (d74f64a) will increase coverage by 0.01%.
The diff coverage is 47.82%.

@@             Coverage Diff              @@
##               main    #6938      +/-   ##
============================================
+ Coverage     11.78%   11.79%   +0.01%     
- Complexity     7673     7685      +12     
============================================
  Files          2505     2505              
  Lines        246161   246252      +91     
  Branches      38390    38401      +11     
============================================
+ Hits          29003    29041      +38     
- Misses       213385   213438      +53     
  Partials       3773     3773

Impacted Files	Coverage Δ
...ck/engine/subsystem/api/storage/VolumeService.java	`0.00% <ø> (ø)`
...tack/storage/endpoint/DefaultEndPointSelector.java	`0.00% <0.00%> (ø)`
...e/cloudstack/storage/volume/VolumeServiceImpl.java	`2.28% <0.00%> (-0.05%)`	⬇️
...in/java/com/cloud/server/ManagementServerImpl.java	`5.72% <0.00%> (-0.01%)`	⬇️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	`14.81% <70.96%> (+1.52%)`	⬆️
...dstack/network/contrail/model/ModelObjectBase.java	`21.15% <0.00%> (-7.70%)`	⬇️
...apache/cloudstack/syslog/AlertsSyslogAppender.java	`56.49% <0.00%> (-2.26%)`	⬇️
...c/main/java/com/cloud/projects/ProjectManager.java	`100.00% <0.00%> (+100.00%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DaanHoogland

looks generally good, but it is good convention to guard log statements of info level and below if they do parameter expansion. Please do so.

JoaoJandre · 2022-12-05T19:18:13Z

looks generally good, but it is good convention to guard log statements of info level and below if they do parameter expansion. Please do so.

As there are no processes being executed only to log the data (the data is already loaded) and we do not have a convention in using is...Enabled for a simple String construction, such the ones I added, I would rather not add it and improve the code readability.

github-actions · 2022-12-12T08:12:48Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2022-12-12T13:30:09Z

@JoaoJandre can you look at the conflicts?
And please have a look at #6973 to see if you find that to be an acceptable compromise?

…te-api-to-reassign-volume

github-actions · 2022-12-13T08:17:24Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…te-api-to-reassign-volume

JoaoJandre · 2022-12-13T11:49:57Z

Hello @DaanHoogland, I just solved the conflicts. Regarding your proposal (#6973), I will take a look at it.

github-actions · 2022-12-15T07:35:38Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…te-api-to-reassign-volume

JoaoJandre · 2022-12-19T14:56:22Z

@DaanHoogland , I took a look at your proposal, and as we are working on the Log4j upgrade, as @GutoVeronezi commented (#6973 (comment)), I would rather not applying an intermediate step.

github-actions · 2023-01-04T07:13:09Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

JoaoJandre · 2023-01-17T11:41:45Z

Sorry for the delay @DaanHoogland , I fixed it :)

github-actions · 2023-01-20T09:10:44Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2023-01-20T09:59:34Z

and yet again @JoaoJandre . sorry, during this aheavy merge period we get conflicts a lot. hope you have time for this.

JoaoJandre · 2023-01-20T17:25:14Z

@DaanHoogland No problem :) done

DaanHoogland · 2023-01-23T08:03:10Z

@blueorangutan package

blueorangutan · 2023-01-23T08:04:04Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-01-23T08:57:16Z

Packaging result: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 5370

github-actions · 2023-01-23T09:02:40Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2023-01-23T10:16:52Z

I feel for you @JoaoJandre , yet another set of conflicts.

…n-volume

sonarqubecloud · 2023-01-23T15:47:23Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

29.2% Coverage
0.0% Duplication

DaanHoogland · 2023-01-23T16:23:38Z

@blueorangutan package

blueorangutan · 2023-01-23T16:24:06Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-01-23T17:15:57Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5381

DaanHoogland · 2023-01-24T08:06:28Z

@blueorangutan test

blueorangutan · 2023-01-24T08:07:04Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-01-24T20:12:58Z

Trillian test result (tid-5976)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42177 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6938-t5976-kvm-centos7.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_site2site_vpn_multiple_options	`Failure`	461.52	test_vpc_vpn.py

DaanHoogland · 2023-01-24T20:22:10Z

@blueorangutan test

blueorangutan · 2023-01-24T20:23:04Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-01-25T09:27:20Z

Trillian test result (tid-5991)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45620 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6938-t5991-kvm-centos7.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	651.63	test_kubernetes_clusters.py

vladimirpetrov

LGTM based on manual testing.

Create API to reassign volume

d9733cf

boring-cyborg Bot added component:api component:management-server component:secondary-storage component:ssvm component:storage labels Dec 1, 2022

DaanHoogland reviewed Dec 2, 2022

View reviewed changes

Address reviews

bd1329f

github-actions Bot added the status:has-conflicts label Dec 12, 2022

Merge branch 'main' of https://github.com/apache/cloudstack into crea…

4d2f98f

…te-api-to-reassign-volume

github-actions Bot removed the status:has-conflicts label Dec 12, 2022

github-actions Bot added the status:has-conflicts label Dec 13, 2022

Merge branch 'main' of https://github.com/apache/cloudstack into crea…

6d4b030

…te-api-to-reassign-volume

github-actions Bot removed the status:has-conflicts label Dec 13, 2022

github-actions Bot added the status:has-conflicts label Dec 15, 2022

Merge branch 'main' of https://github.com/apache/cloudstack into crea…

11c4263

…te-api-to-reassign-volume

github-actions Bot removed the status:has-conflicts label Dec 15, 2022

github-actions Bot added the status:has-conflicts label Jan 4, 2023

Merge branch 'main' into create-api-to-reassign-volume

9ec2d19

github-actions Bot removed the status:has-conflicts label Jan 4, 2023

Update schema-41720to41800.sql

6aee94a

github-actions Bot added the status:has-conflicts label Jan 20, 2023

Merge branch 'main' into create-api-to-reassign-volume

21c8e25

github-actions Bot removed the status:has-conflicts label Jan 20, 2023

github-actions Bot added the status:has-conflicts label Jan 23, 2023

Merge remote-tracking branch 'origin/main' into create-api-to-reassig…

690d2c1

…n-volume

github-actions Bot removed the status:has-conflicts label Jan 23, 2023

DaanHoogland assigned vladimirpetrov Jan 25, 2023

vladimirpetrov approved these changes Jan 26, 2023

View reviewed changes

DaanHoogland added this to the 4.18.0.0 milestone Jan 27, 2023

DaanHoogland merged commit 61a7225 into apache:main Jan 27, 2023

Uh oh!

Conversation

JoaoJandre commented Dec 1, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

sonarqubecloud Bot commented Dec 1, 2022

Uh oh!

codecov Bot commented Dec 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoaoJandre commented Dec 5, 2022

Uh oh!

github-actions Bot commented Dec 12, 2022

Uh oh!

DaanHoogland commented Dec 12, 2022

Uh oh!

github-actions Bot commented Dec 13, 2022

Uh oh!

JoaoJandre commented Dec 13, 2022

Uh oh!

github-actions Bot commented Dec 15, 2022

Uh oh!

JoaoJandre commented Dec 19, 2022

Uh oh!

github-actions Bot commented Jan 4, 2023

Uh oh!

JoaoJandre commented Jan 17, 2023

Uh oh!

github-actions Bot commented Jan 20, 2023

Uh oh!

DaanHoogland commented Jan 20, 2023

Uh oh!

JoaoJandre commented Jan 20, 2023

Uh oh!

DaanHoogland commented Jan 23, 2023

Uh oh!

blueorangutan commented Jan 23, 2023

Uh oh!

blueorangutan commented Jan 23, 2023

Uh oh!

github-actions Bot commented Jan 23, 2023

Uh oh!

DaanHoogland commented Jan 23, 2023

Uh oh!

sonarqubecloud Bot commented Jan 23, 2023

Uh oh!

DaanHoogland commented Jan 23, 2023

Uh oh!

blueorangutan commented Jan 23, 2023

Uh oh!

blueorangutan commented Jan 23, 2023

Uh oh!

DaanHoogland commented Jan 24, 2023

Uh oh!

blueorangutan commented Jan 24, 2023

Uh oh!

blueorangutan commented Jan 24, 2023

Uh oh!

DaanHoogland commented Jan 24, 2023

Uh oh!

blueorangutan commented Jan 24, 2023

Uh oh!

blueorangutan commented Jan 25, 2023

Uh oh!

vladimirpetrov left a comment

codecov Bot commented Dec 1, 2022 •

edited

Loading