SAML SLO does not clear session cookies on logout - #14017
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14017 +/- ##
============================================
+ Coverage 3.82% 17.83% +14.00%
- Complexity 0 16023 +16023
============================================
Files 449 5928 +5479
Lines 38177 534404 +496227
Branches 7072 65399 +58327
============================================
+ Hits 1459 95287 +93828
- Misses 36517 428297 +391780
- Partials 201 10820 +10619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19043 |
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM , Tested manually
Session key is cleared and the saml user is able to login after performing a logout
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-16887)
|
Description
This PR...
Fixes: #13997
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?