Skip to content

4.22 Change 2FA Field Type From Password to Text - #13724

Open
daviftorres wants to merge 3 commits into
apache:4.22from
daviftorres:4.22-Replace-a-input-password-with-a-input-for-code-entry
Open

4.22 Change 2FA Field Type From Password to Text#13724
daviftorres wants to merge 3 commits into
apache:4.22from
daviftorres:4.22-Replace-a-input-password-with-a-input-for-code-entry

Conversation

@daviftorres

@daviftorres daviftorres commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is the same as #13671 but now for 4.22

This PR suggest changes to #13337.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@daviftorres daviftorres changed the title 4.22 replace a input password with a input for code entry 4.22 Change 2FA Field Type From Password to Text Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.69%. Comparing base (0339f31) to head (d2f5728).
⚠️ Report is 53 commits behind head on 4.22.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #13724   +/-   ##
=========================================
  Coverage     17.69%   17.69%           
+ Complexity    15833    15832    -1     
=========================================
  Files          5925     5925           
  Lines        533534   533534           
  Branches      65273    65273           
=========================================
+ Hits          94421    94423    +2     
- Misses       428434   428436    +2     
+ Partials      10679    10675    -4     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland

Copy link
Copy Markdown
Contributor

I think we should either accept this or #13723 and merge it forwards.

@DaanHoogland DaanHoogland moved this from Backlog to conflict/waiting in CloudStack Testing Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: conflict/waiting

Development

Successfully merging this pull request may close these issues.

3 participants