vmware: do not check secondary storage and attach ISO when start a system vm

[weizhouapache]

Description

This PR removes unnecessary check on secondary storage and ISO attachment when start a system vm on vmware.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.69%. Comparing base (f4c0c31) to head (3b4a5fb).
⚠️ Report is 54 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...oud/hypervisor/vmware/resource/VmwareResource.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #13031   +/-   ##
=========================================
  Coverage     17.69%   17.69%           
+ Complexity    15833    15830    -3     
=========================================
  Files          5925     5925           
  Lines        533534   533510   -24     
  Branches      65273    65267    -6     
=========================================
+ Hits          94394    94409   +15     
+ Misses       428463   428422   -41     
- Partials      10677    10679    +2     

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.77% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 18623

[DaanHoogland]

does what it says on th4e tin (i.e. clgtm) but would need testing

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19042

[weizhouapache]

@blueorangutan test ol9 vmware-80u3

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-80u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-16864)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 74781 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13031-t16864-vmware-80u3.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	Error	0.00	test_cluster_drs.py
ContextSuite context=TestRouterServices>:setup	Error	0.00	test_routers.py
test_06_stop_cpvm	Error	989.22	test_ssvm.py
test_08_reboot_cpvm	Error	968.99	test_ssvm.py
test_10_reboot_cpvm_forced	Error	1068.26	test_ssvm.py
test_12_destroy_cpvm	Error	984.62	test_ssvm.py